[ROOT6] Updated root to tip of branch master

[smuzaffar]

No description provided.

[smuzaffar]

please test

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_3_X/rootmaster.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e3297/35098/summary.html
COMMIT: f0f5ad9
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8743/35098/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-08-2300/src/DQMOffline/Alignment/src/DiMuonMassBiasClient.cc:2:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/include/c++/11.4.1/bits/unique_ptr.h: In instantiation of 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = RooFitResult]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/include/c++/11.4.1/bits/unique_ptr.h:361:17:   required from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = RooFitResult; _Dp = std::default_delete]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-befc91f348b2b88b0e934010aed7b8db/include/RooAbsPdf.h:158:47:   required from 'RooFitResult* RooAbsPdf::fitTo(RooAbsData&, const CmdArgs_t& ...) [with CmdArgs_t = {RooCmdArg}; RooFit::OwningPtr = RooFitResult*]'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-08-2300/src/DQMOffline/Alignment/src/DiMuonMassBiasClient.cc:372:20:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/include/c++/11.4.1/bits/unique_ptr.h:83:23: error: invalid application of 'sizeof' to incomplete type 'RooFitResult'
   83 |         static_assert(sizeof(_Tp)>0,
      |                       ^~~~~~~~~~~
gmake: *** [tmp/el8_amd64_gcc11/src/DQMOffline/Alignment/src/DQMOfflineAlignment/DiMuonMassBiasClient.cc.o] Error 1
>> Building edm plugin tmp/el8_amd64_gcc11/src/DQMOffline/Alignment/src/DQMOfflineAlignment/libDQMOfflineAlignment.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.4.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find tmp/el8_amd64_gcc11/src/DQMOffline/Alignment/src/DQMOfflineAlignment/DiMuonMassBiasClient.cc.o: No such file or directory


[smuzaffar]

please test with cms-sw/cmssw#42899 for CMSSW_13_3_ROOT6_X

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e3297/35103/summary.html
COMMIT: f0f5ad9
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8743/35103/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @suchandradutta Update of Phase2 Tracker Digitizer to fix an issue in Premixing cmssw#42938
• @CMSTrackingPOG Rename MaxNumberOfCosmicClusters parameter in ClusterChecker cmssw#42943
• @thomreis Use the ratio timing method for ECAL online DQM cmssw#42932
• @jlidrych Removing re-binnning from SiStripBadAPVandHotStripAlgorithm cmssw#42956
• @MaryShooshtari Adding DeepFlavour Jet tags to BTV DQM cmssw#42937
• @bsunanda Phase2-trk10 Possible overlap removal in the T33 version of tracker geometry cmssw#42951
• @iarspider Add missing include to FitWithRooFit.h cmssw#42899
• @mmusich Miscellaneous improvements for DQM/Integration unit tests cmssw#42953
• @mmusich temporarily remove HLT_DoubleMediumDeepTauPFTauHPS35_eta2p1 from phase-2 HLT menu cmssw#42955
• @rovere Improve runTheMatrix interactive shell cmssw#42923
• @ssrothman Deterministic DRN cmssw#42950
• @missirol add hltPrintMenuVersions and utilities for HLT-menu spreadsheets cmssw#42967
• @mmusich Use TriggerResultsFilterFromDB-based selection for Heavy AlCaRecos in pp_on_AA cmssw#42965
• @iarspider Fix maybe-uninitialized warning in MeasurementTrackerImpl::addPhase2Det cmssw#42880
• @cms-sw Update tag for DQM-Integration to V00-04-00 #8745
• @cms-sw Update tag for RecoEgamma-EgammaPhotonProducers to V00-04-00 #8744

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e3297/35103/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e3297/35103/git-merge-result

RelVals

• 250202.181

----- Begin Fatal Exception 10-Oct-2023 08:24:21 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing global end Run run: 1
   [1] Calling method for module DQMGenericClient/'primaryVertexResolutionClient'
   Additional Info:
      [a] Fatal Root Error: @SUB=Minuit2
VariableMetricBuilder Initial matrix not pos.def.

----- End Fatal Exception -------------------------------------------------

[smuzaffar]

lets get this in for more debugging

[nsmith-]

I wonder if there is a way to have

$ root-config --version
6.29.01

print out something more correct? Since as I understand, this is actually one commit above root-project/root@1a029b5 which includes the tag 6.31.01 in the history

[smuzaffar]

@nsmith- , root-project/root@1a029b5 commit was before the tag 6.31.01 , so root-config --version printing 6.29.01 is correct. Next update to root master should print 6.31.01

[nsmith-]

Ok, I misread the github history. Thanks!