PPS pixel topology

[fabferro]

PR description:

The PPS Pixel topology (internal sensor segmentation) was hardwired in the code and prevented the coexistence in the same release of different types of pixel detectors (eg. Run2 and Run3 ones). For testing and validation puposes it's important for PPS to be able to process both Run2 and Run3 data and simulation. This PR removes the old files and allows to manage the detector topology via the EventSetup, so that the same code can be used to processed data taken or simulated with different pixel detectors. The corresponding setup is chosen by means of the Era mechanism.

No changes in the output are expected.

This PR will be followed by the implementation of the new (Run3) detector Geometry.

PR validation:

Private tests with real data and simulation show no difference in the output of PPS detectors.
runTheMatrix tests are successful.

No backport is expected.

[fabferro]

@jan-kaspar @mundim FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32868/21097

• This PR adds an extra 168KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Adding GEN fragment (GluGluTo2Jets_ExHume) specific for PPS wf testing #32765, Patatrack integration - Pixel workflows (12/N) #31854, Move DD4Hep workflows from 13TeV to 14TeV #32857, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Track classifier using TensorFlow - continuation #32128, Phase2 Tracker description change of paradigm, to be compatible with DD4hep #32843

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

CalibPPS/ESProducers
CondCore/CTPPSPlugins
CondFormats/DataRecord
CondFormats/PPSObjects
Configuration/PyReleaseValidation
Geometry/VeryForwardGeometry
RecoPPS/Configuration
RecoPPS/Local
SimPPS/Configuration
SimPPS/PPSPixelDigiProducer
Validation/CTPPS

@andrius-k, @chayanit, @wajidalikhan, @ianna, @kpedro88, @ggovi, @tlampen, @pohsun, @perrotta, @civanch, @yuanchao, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @slava77, @jpata, @francescobrivio, @malbouis, @jordan-martins, @kmaeshima, @christopheralanwest, @srimanob, @rvenditti can you please review it and eventually sign? Thanks.
@makortel, @forthommel, @jan-kaspar, @tocheng, @Martin-Grunewald, @slomeo, @mmusich, @fabiocos, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43d24f/12831/summary.html
COMMIT: b98b0c0
CMSSW: CMSSW_11_3_X_2021-02-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32868/12831/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2751765
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2751742
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[jpata]

+reconstruction

• technical, loads the PPS topology from ES instead of hardcoding (reco changes are minimal)
• no observed reco differences, as expected

[yuanchao]

+1

[civanch]

+1

[srimanob]

+Upgrade

Please make sure to cross-check when pre4 relvals will be available (validation vs pre3).

[fabferro]

@silviodonato : hoping this PR can be merged soon, so that I can proceed with the implementation of the new Run3 geometry. Thanks!

[silviodonato]

@cms-sw/pdmv-l2 @cms-sw/db-l2 do you have any comments?

[chayanit]

+1
I had already signed

[silviodonato]

merge
@ggovi please have a look, especially at CondFormats/PPSObjects