PPS strings --> InputTag #32971

AndreaBellora · 2021-02-23T11:21:24Z

This PR is only to make the input variables of the producers consistent across the board and get the flexibility provided by InputTags. It has been tested both with the reco and PPS direct simulation workflows.

cmsbuild · 2021-02-23T11:27:22Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32971/21209

ERROR: Build errors found during clang-tidy run.

RecoPPS/Local/interface/RPixClusterToHit.h:13:10: error: 'CondFormats/PPSObjects/interface/PPSPixelTopology.h' file not found [clang-diagnostic-error]
#include "CondFormats/PPSObjects/interface/PPSPixelTopology.h"
         ^
Suppressed 2326 warnings (2325 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

AndreaBellora · 2021-02-23T13:08:57Z

Just adding @jan-kaspar @fabferro to the list of people informed of the PR

cmsbuild · 2021-02-23T13:13:19Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32971/21212

ERROR: Build errors found during clang-tidy run.

RecoPPS/Local/interface/RPixClusterToHit.h:13:10: error: 'CondFormats/PPSObjects/interface/PPSPixelTopology.h' file not found [clang-diagnostic-error]
#include "CondFormats/PPSObjects/interface/PPSPixelTopology.h"
         ^
Suppressed 2326 warnings (2325 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

perrotta · 2021-02-23T13:16:34Z

RecoPPS/Local/plugins/CTPPSPixelLocalTrackProducer.cc


-  desc.add<std::string>("label", "ctppsPixelRecHits")
+  desc.add<edm::InputTag>("label", edm::InputTag("ctppsPixelRecHits"))
      ->setComment("label of the RecHits input for the tracking algorithm");


Strictly speaking, this is not a "label" any more: perhaps "tag"?

I agree, it would be definitely clearer to read. I'm updating it.

AndreaBellora · 2021-02-23T13:30:44Z

It's not clear to me why are the checks failing: RecoPPS/Local/interface/RPixClusterToHit.h has not been touched by the PR. Is there anything I should do about it?

perrotta · 2021-02-23T13:39:17Z

It's not clear to me why are the checks failing: RecoPPS/Local/interface/RPixClusterToHit.h has not been touched by the PR. Is there anything I should do about it?

It has been touched by #32868, merged a few hours ago.
You must rebase on a IB which includes it: I would suggest to wait for CMSSW_11_3_X_2021-02-23-1100, which will likely include it

AndreaBellora · 2021-02-23T13:40:36Z

It's not clear to me why are the checks failing: RecoPPS/Local/interface/RPixClusterToHit.h has not been touched by the PR. Is there anything I should do about it?

It has been touched by #32868, merged a few hours ago.
You must rebase on a IB which includes it: I would suggest to wait for CMSSW_11_3_X_2021-02-23-1100, which will likely include it

Thank you very much. I'll wait for it and check how to do it exactly.

cmsbuild · 2021-02-23T13:42:18Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32971/21213

ERROR: Build errors found during clang-tidy run.

RecoPPS/Local/interface/RPixClusterToHit.h:13:10: error: 'CondFormats/PPSObjects/interface/PPSPixelTopology.h' file not found [clang-diagnostic-error]
#include "CondFormats/PPSObjects/interface/PPSPixelTopology.h"
         ^
Suppressed 2326 warnings (2325 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

perrotta · 2021-02-24T07:11:22Z

code-checks

cmsbuild · 2021-02-24T07:16:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32971/21231

This PR adds an extra 16KB to repository

cmsbuild · 2021-02-24T07:16:37Z

A new Pull Request was created by @AndreaBellora for master.

It involves the following packages:

RecoPPS/Local

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jan-kaspar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2021-02-24T07:17:54Z

please test
(it was enough retest based on the lates IB, which already contains the files modified by #32868: no need to rebase this PR)

cmsbuild · 2021-02-24T09:52:12Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32fdec/13057/summary.html
COMMIT: b6b23f9
CMSSW: CMSSW_11_3_X_2021-02-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32971/13057/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750983
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2750960
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

perrotta · 2021-02-24T15:12:19Z

+1

Technical: Pixel digis accessed from the CTPPSPixelClusterProducer via InputTag, and not by the string label any more
Verified that there is no explicit configuration to update anywhere in CMSSW
Jenkins tests pass with no changes, as it should

cmsbuild · 2021-02-24T15:12:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-02-25T03:52:49Z

+1

AndreaBellora added 2 commits February 5, 2021 17:31

Changed std::string to edm::InputTag for consistency

26b2359

std::string --> edm::InputTag in PixelClusterProducer

1b3db7f

cmsbuild added this to the CMSSW_11_3_X milestone Feb 23, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Feb 23, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 23, 2021

Applying code quality checks

6e34250

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 23, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 23, 2021

perrotta reviewed Feb 23, 2021

View reviewed changes

Changed label --> tag

b6b23f9

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 23, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 23, 2021

cmsbuild removed the code-checks-rejected label Feb 24, 2021

cmsbuild added the code-checks-pending label Feb 24, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 24, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 24, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 24, 2021

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Feb 24, 2021

cmsbuild added orp-approved and removed orp-pending labels Feb 25, 2021

cmsbuild merged commit 56f09e9 into cms-sw:master Feb 25, 2021

makortel mentioned this pull request Feb 25, 2021

Unit test failure in Validation/CTPPS #32996

Closed

forthommel mentioned this pull request Feb 25, 2021

[PPS] Fix of validation script #32998

Merged

3 tasks

forthommel deleted the ctpps_pixel_InputTag branch February 25, 2021 15:39

PPS strings --> InputTag #32971

PPS strings --> InputTag #32971

Uh oh!

Conversation

AndreaBellora commented Feb 23, 2021

Uh oh!

cmsbuild commented Feb 23, 2021

Uh oh!

AndreaBellora commented Feb 23, 2021

Uh oh!

cmsbuild commented Feb 23, 2021

Uh oh!

perrotta Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

AndreaBellora Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

AndreaBellora commented Feb 23, 2021

Uh oh!

perrotta commented Feb 23, 2021

Uh oh!

AndreaBellora commented Feb 23, 2021

Uh oh!

cmsbuild commented Feb 23, 2021

Uh oh!

perrotta commented Feb 24, 2021

Uh oh!

cmsbuild commented Feb 24, 2021

Uh oh!

cmsbuild commented Feb 24, 2021

Uh oh!

perrotta commented Feb 24, 2021

Uh oh!

cmsbuild commented Feb 24, 2021

Comparison Summary

Uh oh!

perrotta commented Feb 24, 2021

Uh oh!

cmsbuild commented Feb 24, 2021

Uh oh!

qliphy commented Feb 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants