Skip to content

Conversation

@srimanob
Copy link
Contributor

PR description:

This PR is to create updated detector geometries with square (T22) and 3D_pixel (T23) trackers with recent subdetectors (D76).

The next step/PR is to clean up obsolete geometries.

PR validation:

Test with

runTheMatrix.py -w upgrade -l 35434.0,35834.0 --wm init

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport is needed.

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild cmsbuild added this to the CMSSW_11_3_X milestone Feb 19, 2021
@srimanob srimanob changed the title Add new D78,D79 geometry based on D76 with T22,T23 Add new D78,D79 geometries based on D76 with T22,T23 Feb 19, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32952/21188

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Configuration/Eras
Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences

@civanch, @Dr15Jones, @jordan-martins, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @makortel, @franzoni, @silviodonato, @kpedro88, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb4978/12989/summary.html
COMMIT: 6b73d08
CMSSW: CMSSW_11_3_X_2021-02-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32952/12989/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test2026Geometry had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2750954
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32952/21193

@srimanob
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb4978/12998/summary.html
COMMIT: c60e908
CMSSW: CMSSW_11_3_X_2021-02-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32952/12998/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2511 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 50110
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2700851
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@srimanob
Copy link
Contributor Author

+Upgrade

@cvuosalo
Copy link
Contributor

Workflow 11634.911 in the comparison tests somehow got a new random seed, which created statistical fluctuations in the results. The differences are not significant.

@cvuosalo
Copy link
Contributor

+1

@chayanit
Copy link

+1

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 6393ecf into cms-sw:master Feb 23, 2021
@makortel
Copy link
Contributor

Seems that this PR could be causing workflow failures in CMSSW_11_3 2021-02-23-2300, see #32986

@srimanob srimanob deleted the 11_3_D78D79Geometry branch March 4, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants