-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add new D78,D79 geometries based on D76 with T22,T23 #32952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32952/21188
|
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages: Configuration/Eras @civanch, @Dr15Jones, @jordan-martins, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @makortel, @franzoni, @silviodonato, @kpedro88, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test test2026Geometry had ERRORS Comparison SummarySummary:
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32952/21193
|
|
Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb4978/12998/summary.html Comparison SummarySummary:
|
|
+Upgrade |
|
Workflow 11634.911 in the comparison tests somehow got a new random seed, which created statistical fluctuations in the results. The differences are not significant. |
|
+1 |
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
|
Seems that this PR could be causing workflow failures in CMSSW_11_3 2021-02-23-2300, see #32986 |
PR description:
This PR is to create updated detector geometries with square (T22) and 3D_pixel (T23) trackers with recent subdetectors (D76).
The next step/PR is to clean up obsolete geometries.
PR validation:
Test with
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport is needed.
Before submitting your pull requests, make sure you followed this checklist: