Calo L1 last20Mismatches Axis Fix Forward Port #32816

aloeliger · 2021-02-04T13:44:41Z

PR description:

This PR modifies the function of the last20Mismatches monitoring element to not include duplicate event mismatch reports on the Y-axis, instead just updating the types of mismatches seen for a given combination of Run, Lumi, and Event. As well, empty Y-axis labels are now simply given their corresponding bin number, to prevent empty string labels causing issues as seen before in #32250. This PR fixes the issue first spotted on this hypernews thread: https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/2192.html

PR validation:

All code compiles, and produces expected plots as seen when using runTheMatrix.py. Using @silviodonato 's method to test the DQM merging step, this code eliminates the merging error seen.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a forward port to the master branch / 11_3_X of #32815. It was created by git cherry-pick -ing the three relevant commits on top of the current state of the master branch. This fix needs to be ported to be available in future production instances of CaloL1 DQM code.

…te y axis entries.

silviodonato · 2021-02-04T13:48:09Z

please test

silviodonato · 2021-02-04T13:48:23Z

urgent

cmsbuild · 2021-02-04T13:59:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32816/21002

This PR adds an extra 24KB to repository

cmsbuild · 2021-02-04T13:59:32Z

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

DQM/L1TMonitor

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-02-04T16:28:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-727477/12711/summary.html
COMMIT: a48ba55
CMSSW: CMSSW_11_3_X_2021-02-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32816/12711/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2752926
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2752894
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 156 log files, 37 edm output root files, 37 DQM output files

silviodonato · 2021-02-05T08:29:18Z

Backport #32815 already merged at the commit a48ba55 ( fbad4f6 )

cmsbuild · 2021-02-05T09:39:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32816/21022

This PR adds an extra 24KB to repository

cmsbuild · 2021-02-05T09:40:07Z

Pull request #32816 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

aloeliger · 2021-02-05T09:45:33Z

@silviodonato I think I have located the issue, a missing "&" (apologies it took me some time to understand and locate this), and the 25202.0 workflow plots look fixed in my test. Is there still in time to add this commit into 11_2_X and the MWGR?

jfernan2 · 2021-02-05T09:46:53Z

please test

jfernan2 · 2021-02-05T09:48:38Z

@silviodonato I think I have located the issue, a missing "&" (apologies it took me some time to understand and locate this), and the 25202.o workflow plots look fixed in my test. Is there still in time to add this commit into 11_2_X and the MWGR?

We can add the fix in 11_2_X at Online DQM at P5 for the GUI used by the shifters, as long as we have a PR, but I understand the fix affects mainly Offline for Tier0

aloeliger · 2021-02-05T09:54:06Z

@silviodonato I think I have located the issue, a missing "&" (apologies it took me some time to understand and locate this), and the 25202.o workflow plots look fixed in my test. Is there still in time to add this commit into 11_2_X and the MWGR?

We can add the fix in 11_2_X at Online DQM at P5 for the GUI used by the shifters, as long as we have a PR, but I understand the fix affects mainly Offline for Tier0

@jfernan2, should I open up a new pull request to 11_2_X with this latest commit?

jfernan2 · 2021-02-05T09:55:59Z

should I open up a new pull request to 11_2_X with this latest commit?
Yes please

aloeliger · 2021-02-05T10:04:39Z

Okay, I have opened a new PR to CMSSW_11_2_X with this fix as well.

cmsbuild · 2021-02-05T12:23:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-727477/12729/summary.html
COMMIT: 10d70eb
CMSSW: CMSSW_11_3_X_2021-02-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32816/12729/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2751765
DQMHistoTests: Total failures: 15
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2751727
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 156 log files, 37 edm output root files, 37 DQM output files

silviodonato · 2021-02-05T12:36:14Z

@aloeliger
in wf136.731 there are still some differences

before

https://tinyurl.com/y3623lfz

and after

https://tinyurl.com/y5jvovou

aloeliger · 2021-02-05T12:53:27Z

@aloeliger
in wf136.731 there are still some differences

This difference seems to be what was expected.

I have removed duplicate events (and therefore labels) from the Y-axis. The PR version does not have duplicate events shown on the Y-axis, instead only reporting each one once, alongside all types of mismatches seen, instead of reporting every mismatch individually.

The current version shows multiple copies of Run 274199, Lumi 21, Event 39733340, alongside multiple reports of the same kind of mismatch.

Comparing between the two, it does not seem like the current PR version of this monitoring element has missed any kinds of mismatches (the previous problem seen on 25202.0), nor does it seem to be reporting mismatches that were not seen.

jfernan2 · 2021-02-05T13:13:38Z

+1

cmsbuild · 2021-02-05T13:14:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-02-05T18:27:01Z

+1

Andrew Loeliger added 3 commits February 4, 2021 08:14

Update CaloL1 last20Mismatches monitoring element to not have duplica…

9742ece

…te y axis entries.

Prevent empty bins in last20Mismatches from having empty labels

1240476

Update commenting typo

a48ba55

cmsbuild added this to the CMSSW_11_3_X milestone Feb 4, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Feb 4, 2021

cmsbuild added tests-started urgent and removed tests-pending labels Feb 4, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 4, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 4, 2021

silviodonato mentioned this pull request Feb 4, 2021

Calo l1 last20 mismatches axis fix #32815

Merged

Change mismatch types vector in updateMismatch to reference

10d70eb

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Feb 5, 2021

cmsbuild removed the code-checks-pending label Feb 5, 2021

cmsbuild added the code-checks-approved label Feb 5, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 5, 2021

aloeliger mentioned this pull request Feb 5, 2021

CaloL1 DQM: Change mismatch types vector in updateMismatch to reference #32828

Merged

cmsbuild added tests-approved and removed tests-started labels Feb 5, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Feb 5, 2021

cmsbuild added orp-approved and removed orp-pending labels Feb 5, 2021

cmsbuild merged commit f1a824a into cms-sw:master Feb 5, 2021

Calo L1 last20Mismatches Axis Fix Forward Port #32816

Calo L1 last20Mismatches Axis Fix Forward Port #32816

Uh oh!

Conversation

aloeliger commented Feb 4, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

silviodonato commented Feb 4, 2021

Uh oh!

silviodonato commented Feb 4, 2021

Uh oh!

cmsbuild commented Feb 4, 2021

Uh oh!

cmsbuild commented Feb 4, 2021

Uh oh!

cmsbuild commented Feb 4, 2021

Comparison Summary

Uh oh!

silviodonato commented Feb 5, 2021

Uh oh!

cmsbuild commented Feb 5, 2021

Uh oh!

cmsbuild commented Feb 5, 2021

Uh oh!

aloeliger commented Feb 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jfernan2 commented Feb 5, 2021

Uh oh!

jfernan2 commented Feb 5, 2021

Uh oh!

aloeliger commented Feb 5, 2021

Uh oh!

jfernan2 commented Feb 5, 2021

Uh oh!

aloeliger commented Feb 5, 2021

Uh oh!

cmsbuild commented Feb 5, 2021

Comparison Summary

Uh oh!

silviodonato commented Feb 5, 2021

Uh oh!

aloeliger commented Feb 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jfernan2 commented Feb 5, 2021

Uh oh!

cmsbuild commented Feb 5, 2021

Uh oh!

silviodonato commented Feb 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aloeliger commented Feb 5, 2021 •

edited

Loading

aloeliger commented Feb 5, 2021 •

edited

Loading