Calo l1 last20 mismatches axis fix

[aloeliger]

PR description:

This PR modifies the function of the last20Mismatches monitoring element to not include duplicate event mismatch reports on the Y-axis, instead just updating the types of mismatches seen for a given combination of Run, Lumi, and Event. As well, empty Y-axis labels are now simply given their corresponding bin number, to prevent empty string labels causing issues as seen before in #32250. This PR fixes the issue first spotted on this hypernews thread: https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/2192.html

PR validation:

All code compiles, and produces expected plots as seen when using runTheMatrix.py. Using @silviodonato 's method to test the DQM merging step, this code eliminates the merging error seen.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport. However, it does need to be forward port-ed to 11_3_X and master.

[cmsbuild]

A new Pull Request was created by @aloeliger for CMSSW_11_2_X.

It involves the following packages:

DQM/L1TMonitor

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test

[aloeliger]

Hello all, I have opened the PR for the fix we discussed in the hypernews thread here, however, it was mentioned that a forwardport to master (11_3_X) needs to be opened as well. I looked at opening a pull request to master, however, it was trying to merge ~76 commits that were not mine there and it would not have allowed it to automatically merge as well. I am afraid I don't know the exact process then for just opening a forward port of this specific set of commits to the master branch. How can I do that?

[silviodonato]

urgent
for the MWGR

[silviodonato]

@aloeliger you can follow these recipes https://cms-sw.github.io/tutorial-resolve-conflicts.html
(the latest release is CMSSW_11_3_X_2021-02-03-2300).

Since you PR is rather easy, perhaps it is quicker to redo the same PR starting from scratch in CMSSW_11_3_X.

[davidlange6]

out of curiousity - why do this complex caching at all and not just fill the histogram directly?

[aloeliger]

out of curiousity - why do this complex caching at all and not just fill the histogram directly?

@davidlange6 It is a thread/stream safety measure to be able to properly count the error values and maximum of error values across multiple streams. I think I asked about this in the original pull request that moved the module into global format (#32004) and the histogram filling is itself not thread safe enough to be able to do this.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-160888/12709/summary.html
COMMIT: fbad4f6
CMSSW: CMSSW_11_2_X_2021-02-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32815/12709/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2529619
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2529587
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 151 log files, 37 edm output root files, 36 DQM output files

[silviodonato]

@aloeliger please have a look at https://tinyurl.com/y4qkyw6b
L1T/L1TStage2CaloLayer1/MismatchDetail/last20Mismatches

[silviodonato]

The baseline plot is
https://tinyurl.com/y5a8bu6u

The plot obtained including the PR is
https://tinyurl.com/y4qkyw6b

[aloeliger]

@aloeliger please have a look at https://tinyurl.com/y4qkyw6b

The axis numbering seems to functioning as intended here. There are no empty string labels, and duplicate event reporting has been removed, but it should be showing event 10 with both Et and feature bit mismatches at least. Sorry, but I need a few minutes to investigate this. This is workflow 25202.0 right?

[silviodonato]

This was 25202.0, but there are similar changes also in other workflows https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2021-02-03-2300+160888/41099/dqm-histo-comparison-summary.html

[silviodonato]

merge
we need this PR for the MWGR.
I keep #32816 open, @aloeliger please comment on that PR when you have understood the changes observed

[jfernan2]

+1
For the records: this PR is being complemented with #32828

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will be automatically merged.