CaloL1 DQM: Change mismatch types vector in updateMismatch to reference

[aloeliger]

PR description:

This PR updates CaloL1 DQM code to change change the updating mismatch vector to a reference, fixing the issue of incorrect last20Mismatches reporting seen at the end of #32815.

PR validation:

All code compiles, and looking at the original 25202.0 workflow last20Mismatches reporting is now behaving as expected.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is now a backport of #32816(?) This is backport-ed for the purpose of hopefully having fully fixed the Calo L1 DQM issue for the MWGR.

[cmsbuild]

A new Pull Request was created by @aloeliger for CMSSW_11_2_X.

It involves the following packages:

DQM/L1TMonitor

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17020d/12730/summary.html
COMMIT: 8ea7a36
CMSSW: CMSSW_11_2_X_2021-02-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32828/12730/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2528845
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2528819
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 151 log files, 37 edm output root files, 36 DQM output files

[jfernan2]

+1
Based on #32816 (comment)
Tested at P5 Online DQM with sucess too

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1