[DD4hep][Simulation] Use regex Comparison if Selection is a Regular Expression #31810

ianna · 2020-10-15T17:49:55Z

PR description:

Allow to select correct sensitive detectors when their SpecPars defined as regular expressions

Note: needs a cms-sw/cmsdist#6315

@bsunanda - FYI

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-10-15T17:50:16Z

The code-checks are being triggered in jenkins.

ianna · 2020-10-15T17:52:58Z

please test with cms-sw/cmsdist#6315

cmsbuild · 2020-10-15T17:56:34Z

-code-checks

ERROR: Build errors found during clang-tidy run.

SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:45:25: error: no member named 'compareEqualName' in namespace 'dd4hep::dd'; did you mean 'compareEqual'? [clang-diagnostic-error]
        if (dd4hep::dd::compareEqualName(dd4hep::dd::noNamespace(it.first.name()), dd4hep::dd::realTopName(pit))) {
                        ^~~~~~~~~~~~~~~~
                        compareEqual
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2020-10-15T18:19:59Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-15T18:25:59Z

-code-checks

ERROR: Build errors found during clang-tidy run.

SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:44:33: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (auto const &pit : fit.second->paths) {
                                ^
                                ->
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:44:34: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (auto const &pit : fit.second->paths) {
                                 ^
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:45:25: error: no member named 'compareEqualName' in namespace 'dd4hep::dd'; did you mean 'compareEqual'? [clang-diagnostic-error]
        if (dd4hep::dd::compareEqualName(dd4hep::dd::noNamespace(it.first.name()), dd4hep::dd::realTopName(pit))) {
                        ^~~~~~~~~~~~~~~~
                        compareEqual
--
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:46:52: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
          dd4hepVec.emplace_back(&*it.second, &*fit.second);
                                                   ^
                                                   ->
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:46:53: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
          dd4hepVec.emplace_back(&*it.second, &*fit.second);
                                                    ^
Suppressed 2251 warnings (2250 in non-user code, 1 with check filters).
--
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:116:33: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (auto const& pit : fit.second->paths) {
                                ^
                                ->
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:116:34: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (auto const& pit : fit.second->paths) {
                                 ^
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:118:110: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
          dd4hepVec_.emplace_back(std::make_pair<G4LogicalVolume*, const dd4hep::SpecPar*>(&*it.second, &*fit.second));
                                                                                                             ^
                                                                                                             ->
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:118:111: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
          dd4hepVec_.emplace_back(std::make_pair<G4LogicalVolume*, const dd4hep::SpecPar*>(&*it.second, &*fit.second));
                                                                                                              ^
Suppressed 2263 warnings (2262 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2020-10-15T19:05:45Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-15T19:12:51Z

-code-checks

ERROR: Build errors found during clang-tidy run.

SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:44:33: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (auto const &pit : fit.second->paths) {
                                ^
                                ->
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:44:34: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (auto const &pit : fit.second->paths) {
                                 ^
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:45:25: error: no member named 'compareEqualName' in namespace 'dd4hep::dd'; did you mean 'compareEqual'? [clang-diagnostic-error]
        if (dd4hep::dd::compareEqualName(dd4hep::dd::realTopName(pit), dd4hep::dd::noNamespace(it.first.name()))) {
                        ^~~~~~~~~~~~~~~~
                        compareEqual
--
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:46:52: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
          dd4hepVec.emplace_back(&*it.second, &*fit.second);
                                                   ^
                                                   ->
SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc:46:53: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
          dd4hepVec.emplace_back(&*it.second, &*fit.second);
                                                    ^
Suppressed 2251 warnings (2250 in non-user code, 1 with check filters).
--
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:116:33: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
      for (auto const& pit : fit.second->paths) {
                                ^
                                ->
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:116:34: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
      for (auto const& pit : fit.second->paths) {
                                 ^
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:118:110: error: member reference type 'const dd4hep::SpecPar *const' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
          dd4hepVec_.emplace_back(std::make_pair<G4LogicalVolume*, const dd4hep::SpecPar*>(&*it.second, &*fit.second));
                                                                                                             ^
                                                                                                             ->
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:118:111: error: no member named 'second' in 'dd4hep::SpecPar' [clang-diagnostic-error]
          dd4hepVec_.emplace_back(std::make_pair<G4LogicalVolume*, const dd4hep::SpecPar*>(&*it.second, &*fit.second));
                                                                                                              ^
Suppressed 2263 warnings (2262 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

ianna · 2020-10-15T19:13:10Z

@bsunanda - EB simhits are there now. I used CMSSW_11_2_X_2020-10-13-2300, so it may not have all the fixes for numbering yet.

bsunanda · 2020-10-15T20:14:38Z

Yana please try #31813 on top this. It will clear the other issues hopefully

…

________________________________ From: Ianna Osborne [notifications@github.com] Sent: 15 October 2020 21:13 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] [DD4hep][Simulation] Use regex Comparison if Selection is a Regular Expression (#31810) @bsunanda<https://github.com/bsunanda> - EB simhits are there now. I used CMSSW_11_2_X_2020-10-13-2300, so it may not have all the fixes for numbering yet. [Screenshot 2020-10-15 at 21 10 16]<https://user-images.githubusercontent.com/1390682/96175267-f21d9480-0f2a-11eb-907a-f20bb6990501.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#31810 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOXPFENC3B5BCMP4PYTSK5CVNANCNFSM4SSJX2ZQ>.

ianna · 2020-10-15T21:18:09Z

Yana please try #31813 on top this. It will clear the other issues hopefully
…

Thanks, @bsunanda ! Yes, Ecal Barrel simhits look reasonable now:

The Ecal endcap looks like its reflected volumes are missing or mis-placed.

cmsbuild · 2020-10-19T13:01:04Z

-1

Tested at: 46f7001

CMSSW: CMSSW_11_2_X_2020-10-18-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3ebf7/10073/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found compilation error when building:

Copying tmp/slc7_amd64_gcc820/src/SimG4Core/DD4hepGeometry/test/DD4hepGeometryTestDriver/DD4hepGeometryTestDriver to productstore area:
Entering library rule at src/SimG4Core/DD4hepGeometry/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestG4Geometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc: In lambda function:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:109:35: error: base operand of '->' has non-pointer type 'const std::pair, const dd4hep::SpecPar*>'
         for (auto const& sit : fit->spars) {
                                   ^~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:112:35: error: base operand of '->' has non-pointer type 'const std::pair, const dd4hep::SpecPar*>'
         for (auto const& pit : fit->paths) {
                                   ^~

Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/src/DD4hep_DDDWorld.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/dummyMain.cpp
Entering library rule at src/SimG4Core/DD4hepGeometry/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestG4Geometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:109:35: error: member reference type 'const std::pair, std::allocator >, const dd4hep::SpecPar *>' is not a pointer; did you mean to use '.'?
        for (auto const& sit : fit->spars) {
                               ~~~^~
                                  .
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-18-2300/src/SimG4Core/DD4hepGeometry/test/plugins/DD4hepTestDDDWorld.cc:109:37: error: no member named 'spars' in 'std::pair, std::allocator >, const dd4hep::SpecPar *>'
        for (auto const& sit : fit->spars) {

cmsbuild · 2020-10-19T13:01:12Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-10-19T14:00:01Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6315,#31770,#31821

CMSSW_11_2_X_2020-10-19-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10079/console Started: 2020/10/19 16:01

cmsbuild · 2020-10-19T19:10:31Z

-1

Tested at: 46f7001

CMSSW: CMSSW_11_2_X_2020-10-19-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3ebf7/10079/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test GeometryDTGeometryBuilderTestDriver had ERRORS
---> test GeometryTrackerGeometryBuilderTestDriver had ERRORS

cmsbuild · 2020-10-19T19:10:39Z

Comparison job queued.

cmsbuild · 2020-10-19T20:26:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3ebf7/10079/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2543752
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2543723
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-10-20T20:55:43Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6315,#31770,#31821

CMSSW_11_2_X_2020-10-20-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10156/console Started: 2020/10/20 22:57

cmsbuild · 2020-10-20T21:35:39Z

-1
@ianna This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31810/10156/git-merge-result

cmsbuild · 2020-10-21T06:22:09Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6315,#31770,#31821

CMSSW_11_2_X_2020-10-20-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10162/console Started: 2020/10/21 08:24

cmsbuild · 2020-10-21T06:49:01Z

-1
@ianna This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31810/10162/git-merge-result

ianna · 2020-10-21T22:04:14Z

merged in #31879

cmsbuild added this to the CMSSW_11_2_X milestone Oct 15, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Oct 15, 2020

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Oct 15, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending code-checks-rejected labels Oct 15, 2020

cmsbuild added the code-checks-pending label Oct 15, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 15, 2020

bsunanda mentioned this pull request Oct 16, 2020

Run3-gex21 Correct ECAL numbering schemes to work for dd4hep #31813

Merged

Ianna Osborne and others added 2 commits October 19, 2020 11:55

replace tbb containers with std ones

4dfda88

final changes to replace tbb with std - requires updated dd4hep

4d13472

cmsbuild mentioned this pull request Oct 19, 2020

Run3-gex24 Try to sort out the issue of SimHit for muons using dd4hep #31832

Merged

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Oct 19, 2020

cmsbuild added tests-started and removed tests-rejected labels Oct 19, 2020

cmsbuild added comparison-pending tests-rejected and removed comparison-notrun tests-started labels Oct 19, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 19, 2020

cmsbuild added tests-started and removed tests-rejected labels Oct 20, 2020

ianna mentioned this pull request Oct 21, 2020

[DD4hep] Update to master 21 10 2020 #31879

Merged

cmsbuild mentioned this pull request Oct 21, 2020

[DD4hep] Reintroduce Namespace #31886

Merged

ianna closed this Oct 21, 2020

ianna deleted the dd4hep-sim-sens-det-regex-v1 branch June 25, 2025 18:51

[DD4hep][Simulation] Use regex Comparison if Selection is a Regular Expression #31810

[DD4hep][Simulation] Use regex Comparison if Selection is a Regular Expression #31810

Uh oh!

Conversation

ianna commented Oct 15, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

cmsbuild commented Oct 15, 2020

Uh oh!

ianna commented Oct 15, 2020

Uh oh!

cmsbuild commented Oct 15, 2020

Uh oh!

cmsbuild commented Oct 15, 2020

Uh oh!

cmsbuild commented Oct 15, 2020

Uh oh!

cmsbuild commented Oct 15, 2020

Uh oh!

cmsbuild commented Oct 15, 2020

Uh oh!

ianna commented Oct 15, 2020

Uh oh!

bsunanda commented Oct 15, 2020 via email

Uh oh!

ianna commented Oct 15, 2020

Uh oh!

cmsbuild commented Oct 19, 2020

Uh oh!

cmsbuild commented Oct 19, 2020

Uh oh!

cmsbuild commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 19, 2020

Uh oh!

cmsbuild commented Oct 19, 2020

Uh oh!

cmsbuild commented Oct 19, 2020

Uh oh!

cmsbuild commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 20, 2020

Uh oh!

cmsbuild commented Oct 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 21, 2020

Uh oh!

ianna commented Oct 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmsbuild commented Oct 19, 2020 •

edited

Loading

cmsbuild commented Oct 20, 2020 •

edited

Loading

cmsbuild commented Oct 21, 2020 •

edited

Loading