Run3-gex24 Try to sort out the issue of SimHit for muons using dd4hep #31832

bsunanda · 2020-10-16T21:39:33Z

PR description:

Try to sort out the issue of SimHit for muons using dd4hep

PR validation:

Test using the runTheMatrix scenario 11634.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2020-10-16T21:40:02Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-16T21:47:15Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31832/19155

This PR adds an extra 52KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CondFormats/GeometryObjects/src/classes.h modified in PR(s): GeometricDetExtra, PGeometricDetExtra schema removal #31729
- File CondFormats/GeometryObjects/src/classes_def.xml modified in PR(s): GeometricDetExtra, PGeometricDetExtra schema removal #31729
- File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml modified in PR(s): [DD4hep] Final Changes to Replace tbb with std - requires a DD4hep update #31770, [DD4hep] Update to DD4hep master of 16.10.2020 #31821

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31832/19155/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31832/19155/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31832/19155/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31832/19155/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-10-16T21:52:25Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-16T21:58:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31832/19156

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CondFormats/GeometryObjects/src/classes.h modified in PR(s): GeometricDetExtra, PGeometricDetExtra schema removal #31729
- File CondFormats/GeometryObjects/src/classes_def.xml modified in PR(s): GeometricDetExtra, PGeometricDetExtra schema removal #31729
- File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml modified in PR(s): [DD4hep] Final Changes to Replace tbb with std - requires a DD4hep update #31770, [DD4hep] Update to DD4hep master of 16.10.2020 #31821

cmsbuild · 2020-10-16T21:58:55Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

CondFormats/GeometryObjects
Configuration/Geometry
Geometry/CMSCommonData
Geometry/MuonCommonData
Geometry/MuonNumbering
SimG4CMS/Muon

@civanch, @Dr15Jones, @makortel, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @yuanchao, @tocheng, @tlampen, @ggovi, @pohsun, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @slomeo, @rovere, @Martin-Grunewald, @tocheng, @ptcox, @mmusich, @fabiocos, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2020-10-16T23:31:43Z

@cmsbuild Please test

cmsbuild · 2020-10-16T23:32:05Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-16-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10039/console Started: 2020/10/17 02:01

cmsbuild · 2020-10-17T01:08:16Z

+1
Tested at: aaa0f06
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d7127/10039/summary.html
CMSSW: CMSSW_11_2_X_2020-10-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-17T01:08:18Z

Comparison job queued.

cmsbuild · 2020-10-20T20:56:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31832/19268

This PR adds an extra 20KB to repository
Found files with invalid states:
- Geometry/MuonCommonData/data/muonNumbering/2021/v2x/muonNumbering.xml:
  - Added: d3c347a
  - Deleted: 9092c57
There are other open Pull requests which might conflict with changes you have proposed:
- File CondFormats/GeometryObjects/src/classes.h modified in PR(s): Cleaning of PGeometricTimingDetExtra #31875
- File CondFormats/GeometryObjects/src/classes_def.xml modified in PR(s): Cleaning of PGeometricTimingDetExtra #31875
- File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml modified in PR(s): [DD4hep] Final Changes to Replace tbb with std - requires a DD4hep update #31770, [DD4hep][Simulation] Use regex Comparison if Selection is a Regular Expression #31810, [DD4hep] Update to DD4hep master of 16.10.2020 #31821

cmsbuild · 2020-10-20T20:57:06Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-20-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10157/console Started: 2020/10/20 22:57

cmsbuild · 2020-10-20T20:57:06Z

Pull request #31832 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @yuanchao, @tocheng, @tlampen, @ggovi, @pohsun, @kpedro88 can you please check and sign again.

cmsbuild · 2020-10-20T22:07:27Z

+1
Tested at: b301e10
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d7127/10157/summary.html
CMSSW: CMSSW_11_2_X_2020-10-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-20T22:07:29Z

Comparison job queued.

cmsbuild · 2020-10-20T23:47:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d7127/10157/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544100
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544071
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

silviodonato · 2020-10-21T07:27:34Z

+1

civanch · 2020-10-21T08:18:18Z

+1

bsunanda · 2020-10-21T11:11:59Z

@kpedro88 @christopheralanwest @ggovi Could you please sign this PR

kpedro88 · 2020-10-21T14:28:07Z

+upgrade

bsunanda · 2020-10-21T14:31:31Z

@silviodonato Could this be a part of pre8?

silviodonato · 2020-10-21T17:27:27Z

merge

Try to sort out the issue of SimHit for muons using dd4hep

d3c347a

cmsbuild added this to the CMSSW_11_2_X milestone Oct 16, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending db-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Oct 16, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 16, 2020

Code check

aaa0f06

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 16, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 16, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 16, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 20, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 20, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 20, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 20, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 21, 2020

cmsbuild added geometry-approved simulation-approved and removed geometry-pending simulation-pending labels Oct 21, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 21, 2020

cmsbuild merged commit abe60ac into cms-sw:master Oct 21, 2020

silviodonato mentioned this pull request Oct 22, 2020

Segmentation violation in workflows 33034.0 and 33434.0 (geometry D72) #31895

Closed

Run3-gex24 Try to sort out the issue of SimHit for muons using dd4hep #31832

Run3-gex24 Try to sort out the issue of SimHit for muons using dd4hep #31832

Uh oh!

Conversation

bsunanda commented Oct 16, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020

Uh oh!

bsunanda commented Oct 16, 2020

Uh oh!

cmsbuild commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 17, 2020

Uh oh!

cmsbuild commented Oct 17, 2020

Uh oh!

cmsbuild commented Oct 20, 2020

Uh oh!

cmsbuild commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 20, 2020

Uh oh!

cmsbuild commented Oct 20, 2020

Uh oh!

cmsbuild commented Oct 20, 2020

Uh oh!

cmsbuild commented Oct 20, 2020

Uh oh!

silviodonato commented Oct 21, 2020

Uh oh!

civanch commented Oct 21, 2020

Uh oh!

bsunanda commented Oct 21, 2020

Uh oh!

kpedro88 commented Oct 21, 2020

Uh oh!

bsunanda commented Oct 21, 2020

Uh oh!

silviodonato commented Oct 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cmsbuild commented Oct 16, 2020 •

edited

Loading

cmsbuild commented Oct 20, 2020 •

edited

Loading