[DD4hep] Reintroduce Namespace

[ianna]

PR description:

• Record namespace (e.g. XML file name) for every Volume

Note: now there are two member functions in DDNamespace that do pretty much the same thing: addVolumeNS and addVolume. A general cleanup will be done to keep the latter after this PR is merged.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31886/19287

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc modified in PR(s): [DD4hep] Final Changes to Replace tbb with std - requires a DD4hep update #31770, [DD4hep] Update to master 21 10 2020 #31879, [DD4hep][Simulation] Use regex Comparison if Selection is a Regular Expression #31810, [DD4hep] Update to DD4hep master of 16.10.2020 #31821
  • File DetectorDescription/DDCMS/src/DDNamespace.cc modified in PR(s): [DD4hep] Update to master 21 10 2020 #31879, [DD4hep] Update to DD4hep master of 16.10.2020 #31821

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @JanFSchulte, @VinInn, @ebrondol, @ghugo83, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-20-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10181/console Started: 2020/10/21 18:17

[cmsbuild]

-1

Tested at: b5e425c

CMSSW: CMSSW_11_2_X_2020-10-20-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c34e8/10181/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testDD4hepFilteredViewGoTo had ERRORS
---> test testDD4hepFilteredViewGet had ERRORS
---> test testDD4hepFilteredViewFind had ERRORS
---> test GeometryMTDCommonDataTestDriver had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c34e8/10181/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544100
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544077
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cmsbuild]

+1
Tested at: cef79dd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c34e8/10247/summary.html
CMSSW: CMSSW_11_2_X_2020-10-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c34e8/10247/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544110
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544081
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[ianna]

+1

[ianna]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[smuzaffar]

@ianna , could this PR be the reason behind failing unit tests in IBs? Tests are failing due to differences in the logs

[smuzaffar]

ok #31934 might fix the issue

[ianna]

ok #31934 might fix the issue

yes, it does for a DT test. I'm waiting for confirmation from @fabiocos if I should fix the MTD code as well.

[ianna]

ok #31934 might fix the issue

yes, it does for a DT test. I'm waiting for confirmation from @fabiocos if I should fix the MTD code as well.

Ok, #31934 fixes MTD tests as well