Skip to content

Conversation

@emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Dec 24, 2025

This PR addresses #5726

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Updates the currently comma-separated accessibility features list into an actual list for ... accessibility!

How Can This Be Tested/Reviewed?

The list of accessibility features under the Features section on a listing should now appear as an actual list. If there are more than 6, it will split into 2 columns, though go back to 1 on mobile. We are now also sorting alphabetically.

Example > 6 listing with before and after

Image Image

Example <= 6 with before and after

Image Image

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify
Copy link

netlify bot commented Dec 24, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 4a6992f
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/694c345a4156c10008a5544f
😎 Deploy Preview https://deploy-preview-5725--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 24, 2025

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit 4a6992f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/694c345a3d0ba60008480328
😎 Deploy Preview https://deploy-preview-5725--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 24, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 4a6992f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/694c345a4a1fca0008be393a
😎 Deploy Preview https://deploy-preview-5725--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 24, 2025

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit 4a6992f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/694c345a872ece000875d238
😎 Deploy Preview https://deploy-preview-5725--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 24, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 4a6992f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/694c345ad4f82e0008d1152c
😎 Deploy Preview https://deploy-preview-5725--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 24, 2025

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit 4a6992f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/694c345a1311c00008c4b366
😎 Deploy Preview https://deploy-preview-5725--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski marked this pull request as ready for review December 24, 2025 18:53
@emilyjablonski emilyjablonski added the 1 review needed Requires 1 more review before ready to merge label Dec 24, 2025
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YazeedLoonat YazeedLoonat added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Dec 24, 2025
@emilyjablonski emilyjablonski merged commit 62cc42e into main Dec 24, 2025
35 of 36 checks passed
@emilyjablonski emilyjablonski deleted the a11y-lists branch December 24, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants