-
Notifications
You must be signed in to change notification settings - Fork 40
feat: Leasing Agent - Update #5699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionally looks good. Mostly just questions and some nits
...s/partners/src/components/listings/PaperListingDetails/sections/DetailApplicationAddress.tsx
Outdated
Show resolved
Hide resolved
sites/public/__tests__/components/listing/listing_sections/LeasingAgent.test.tsx
Outdated
Show resolved
Hide resolved
sites/public/__tests__/components/listing/listing_sections/LeasingAgent.test.tsx
Outdated
Show resolved
Hide resolved
sites/public/src/components/listing/listing_sections/LeasingAgent.tsx
Outdated
Show resolved
Hide resolved
sites/public/__tests__/components/listing/listing_sections/LeasingAgent.test.tsx
Show resolved
Hide resolved
ludtkemorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This PR addresses #5479
Description
For this ticket we wanted to add a new feature flag (
FeatureFlagEnum.enableLeasingAgentAltText) so we can show alternative text when its true. (e.g Leasing agent" to "Leasing agent or property manager)How Can This Be Tested/Reviewed?
Feature flag ON
Steps:
1- navigate to the partners site
2-Click on Add listing
3-select any jurisdiction
3-Navigate to the application process tab
4- Verify the leasing Section has this copy:
Partners:
a)Leasing agent or property manager
b)Provide details about the leasing agent or property manager who will be managing the application process
c)Leasing agent or property manager name
d)Leasing agent or property manager title
e)Leasing agent or property manager address
Partners:
Public, which should include translations:
Contact leasing agent or property manager
feature flag OFF
Same steps of above but you should see for copy:
Partners:
a)The section title of Leasing agent
b)The subtitle of Provide details about the leasing agent who will be managing the application process.
c)Leasing agent name
d)Leasing agent title
e) Leasing agent address
Public, which should include translations:
Contact leasing agent
Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: