Skip to content

Conversation

@millord
Copy link
Collaborator

@millord millord commented Dec 15, 2025

This PR addresses #5479

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

For this ticket we wanted to add a new feature flag (FeatureFlagEnum.enableLeasingAgentAltText) so we can show alternative text when its true. (e.g Leasing agent" to "Leasing agent or property manager)

How Can This Be Tested/Reviewed?

Feature flag ON
Steps:
1- navigate to the partners site
2-Click on Add listing
3-select any jurisdiction
3-Navigate to the application process tab
4- Verify the leasing Section has this copy:

Partners:
a)Leasing agent or property manager
b)Provide details about the leasing agent or property manager who will be managing the application process
c)Leasing agent or property manager name
d)Leasing agent or property manager title
e)Leasing agent or property manager address

Partners:

image

Public, which should include translations:
Contact leasing agent or property manager

image

feature flag OFF
Same steps of above but you should see for copy:

Partners:
a)The section title of Leasing agent
b)The subtitle of Provide details about the leasing agent who will be managing the application process.
c)Leasing agent name
d)Leasing agent title
e) Leasing agent address

image

Public, which should include translations:
Contact leasing agent

image

Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@millord millord changed the title added feature flag feat: Leasing Agent - Update Dec 15, 2025
@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit 01d2bc3
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/694aa6cc47ed170008e91172
😎 Deploy Preview https://deploy-preview-5699--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit 01d2bc3
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/694aa6ce734d1c0009534b23
😎 Deploy Preview https://deploy-preview-5699--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 2204746
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/694066ed8a1f980008ef523a
😎 Deploy Preview https://deploy-preview-5699--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 01d2bc3
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/694aa6ccb8cf2e000820233a
😎 Deploy Preview https://deploy-preview-5699--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 01d2bc3
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/694aa6cc94763100085ff14c
😎 Deploy Preview https://deploy-preview-5699--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit 01d2bc3
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/694aa6cce50ba300080025a6
😎 Deploy Preview https://deploy-preview-5699--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 01d2bc3
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/694aa6cc4bc4cd0007eefb01
😎 Deploy Preview https://deploy-preview-5699--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@millord millord marked this pull request as ready for review December 18, 2025 19:53
@millord millord added the 1 review needed Requires 1 more review before ready to merge label Dec 18, 2025
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionally looks good. Mostly just questions and some nits

@ludtkemorgan ludtkemorgan added needs changes The author must make changes and then re-request review before merging questions labels Dec 22, 2025
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed needs changes The author must make changes and then re-request review before merging 1 review needed Requires 1 more review before ready to merge questions labels Jan 6, 2026
@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 3935d81
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/695d99681c1ad7000974c990
😎 Deploy Preview https://deploy-preview-5699--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 3935d81
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/695d9968db1f9800082d8a68
😎 Deploy Preview https://deploy-preview-5699--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit 3935d81
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/695d996849c2260008584f54
😎 Deploy Preview https://deploy-preview-5699--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 3935d81
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/695d9968681ca50008dd892e
😎 Deploy Preview https://deploy-preview-5699--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit 3935d81
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/695d9968eb79fa00088d1028
😎 Deploy Preview https://deploy-preview-5699--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit 3935d81
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/695d99684151f60008659535
😎 Deploy Preview https://deploy-preview-5699--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@millord millord merged commit 286a73b into main Jan 6, 2026
35 checks passed
@millord millord deleted the 5479/leasing-agent-update branch January 6, 2026 23:51
@millord millord added ready for qa Ready to be QA’d and removed ready to merge Should be applied when a PR has been reviewed and approved labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for qa Ready to be QA’d

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants