You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this pr is to fix an issue with #5699 change that was merged. We were using doJurisdictionsHaveFeatureFlagOn to check for the feature flag value which is taking account if the user is signed in. This was creating an issue in the public site in particular not showing the right label when the enableLeasingAgentAltText flag was true.
How Can This Be Tested/Reviewed?
Feature flag ON
Steps:
1- navigate to the partners site
2-Click on Add listing
3-select any jurisdiction
3-Navigate to the application process tab
4- Verify the leasing Section has this copy:
Partners:
a)Leasing agent or property manager
b)Provide details about the leasing agent or property manager who will be managing the application process
c)Leasing agent or property manager name
d)Leasing agent or property manager title
e)Leasing agent or property manager address
Partners:
Public, which should include translations:
Contact leasing agent or property manager
Steps:
1- navigate to the public site
2-Click on a listing
3-Navigate to the detail page
4- Verify the Contact leasing Section has this copy:
feature flag OFF
Same steps of above but you should see for copy:
Partners:
a)The section title of Leasing agent
b)The subtitle of Provide details about the leasing agent who will be managing the application process.
c)Leasing agent name
d)Leasing agent title
e) Leasing agent address
Public, which should include translations:
Contact leasing agent
Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.
Author Checklist:
Added QA notes to the issue with applicable URLs
Reviewed in a desktop view
Reviewed in a mobile view
Reviewed considering accessibility
Added tests covering the changes
Made corresponding changes to the documentation
Ran yarn generate:client and/or created a migration when required
Review Process:
Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates
ready to mergeShould be applied when a PR has been reviewed and approved
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5479
Description
The purpose of this pr is to fix an issue with #5699 change that was merged. We were using doJurisdictionsHaveFeatureFlagOn to check for the feature flag value which is taking account if the user is signed in. This was creating an issue in the public site in particular not showing the right label when the enableLeasingAgentAltText flag was true.
How Can This Be Tested/Reviewed?
Feature flag ON
Steps:
1- navigate to the partners site
2-Click on Add listing
3-select any jurisdiction
3-Navigate to the application process tab
4- Verify the leasing Section has this copy:
Partners:
a)Leasing agent or property manager
b)Provide details about the leasing agent or property manager who will be managing the application process
c)Leasing agent or property manager name
d)Leasing agent or property manager title
e)Leasing agent or property manager address
Partners:
Public, which should include translations:
Contact leasing agent or property manager
Steps:
1- navigate to the public site
2-Click on a listing
3-Navigate to the detail page
4- Verify the Contact leasing Section has this copy:
feature flag OFF
Same steps of above but you should see for copy:
Partners:
a)The section title of Leasing agent
b)The subtitle of Provide details about the leasing agent who will be managing the application process.
c)Leasing agent name
d)Leasing agent title
e) Leasing agent address
Public, which should include translations:
Contact leasing agent
Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: