Skip to content

Conversation

@millord
Copy link
Collaborator

@millord millord commented Jan 9, 2026

This PR addresses #5479

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The purpose of this pr is to fix an issue with #5699 change that was merged. We were using doJurisdictionsHaveFeatureFlagOn to check for the feature flag value which is taking account if the user is signed in. This was creating an issue in the public site in particular not showing the right label when the enableLeasingAgentAltText flag was true.

How Can This Be Tested/Reviewed?

Feature flag ON
Steps:
1- navigate to the partners site
2-Click on Add listing
3-select any jurisdiction
3-Navigate to the application process tab
4- Verify the leasing Section has this copy:

Partners:
a)Leasing agent or property manager
b)Provide details about the leasing agent or property manager who will be managing the application process
c)Leasing agent or property manager name
d)Leasing agent or property manager title
e)Leasing agent or property manager address

Partners:

image

Public, which should include translations:
Contact leasing agent or property manager

Steps:
1- navigate to the public site
2-Click on a listing
3-Navigate to the detail page
4- Verify the Contact leasing Section has this copy:

image

feature flag OFF
Same steps of above but you should see for copy:

Partners:
a)The section title of Leasing agent
b)The subtitle of Provide details about the leasing agent who will be managing the application process.
c)Leasing agent name
d)Leasing agent title
e) Leasing agent address

image

Public, which should include translations:
Contact leasing agent

image

Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit f8bc4df
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/696167837291e50008e85b92
😎 Deploy Preview https://deploy-preview-5755--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit f8bc4df
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/69616783077cb70008728d45
😎 Deploy Preview https://deploy-preview-5755--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit f8bc4df
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/696167836655f40008887fc0
😎 Deploy Preview https://deploy-preview-5755--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit f8bc4df
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/69616783905acb000822722f
😎 Deploy Preview https://deploy-preview-5755--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit f8bc4df
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/69616783433e8300082243d0
😎 Deploy Preview https://deploy-preview-5755--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit f8bc4df
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/69616783f89bc500081316e6
😎 Deploy Preview https://deploy-preview-5755--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@millord millord marked this pull request as ready for review January 9, 2026 19:09
@millord millord changed the title updated feature flag check fix:Leasing Agent - Update "Leasing agent" to "Leasing agent or property manager Jan 9, 2026
@ludtkemorgan ludtkemorgan added the ready to merge Should be applied when a PR has been reviewed and approved label Jan 9, 2026
@millord millord merged commit a131e55 into main Jan 9, 2026
35 checks passed
@millord millord deleted the fix/5479-leasing-agent-update branch January 9, 2026 21:05
avrittrohwer pushed a commit to bloom-housing/bloom-la that referenced this pull request Jan 14, 2026
…rty manager (bloom-housing#5755)

fix for Leasing Agent - Update "Leasing agent" to "Leasing agent or property manager not showing proper label issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants