Skip to content

Conversation

akimakinai
Copy link
Contributor

@akimakinai akimakinai commented Sep 27, 2025

Objective

Solution

  • They look like just typos (all in let pass_span = time_span form), so replaced with pass_span.

There's an occurence of this pattern in meshlet/visibility_buffer_raster_node.rs, but it's the variable name that seems incorrect in this case. I renamed it instead.

Testing

  • Running log_diagnostics example no longer crashes on Mac.

@Zeophlite Zeophlite added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen A-Diagnostics Logging, crash handling, error reporting and performance analysis S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 28, 2025
@janhohenheim janhohenheim added this to the 0.17 milestone Sep 28, 2025
@janhohenheim
Copy link
Member

Pinging @jf908 who introduced the relevant lines :)

@akimakinai
Copy link
Contributor Author

Probably time_span should be changed to take encoder rather than being generic over encoder/pass if my understanding above is correct. (As a separate PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

log diagnostics example crash on mac due to RenderDiagnosticsPlugin
3 participants