Fix crash with RenderDiagnosticsPlugin on mac #21238
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
RenderDiagnosticsPlugin
#21167(happens with
trace_tracy
feature too, as it adds the plugin automatically)time_span
inside passes, which go around the check for TIMESTAMP_QUERY_INSIDE_PASSES feature (unsupported on Apple GPU).introduced in Record render diagnostics for all engine passes #19191
Solution
let pass_span = time_span
form), so replaced withpass_span
.There's an occurence of this pattern in
meshlet/visibility_buffer_raster_node.rs
, but it's the variable name that seems incorrect in this case. I renamed it instead.Testing
log_diagnostics
example no longer crashes on Mac.