log diagnostics example crash on mac due to `RenderDiagnosticsPlugin`

[foxzool]

Bevy version and features

example crash on

• 0.17.0.rc
• main branch

0.16 works fine

[Optional] Relevant system information

If you cannot get Bevy to build or run on your machine, please include:

• the Rust version you're using (you can get this by running cargo --version)

> cargo --version
cargo 1.90.0 (840b83a10 2025-07-30)
> rustc --version
rustc 1.90.0 (1159e78c4 2025-09-14)

• the operating system or browser used, including its version
  macOS Sequoia 15.6.1

❯ uname -a
Darwin ZoOL-MBP.local 24.6.0 Darwin Kernel Version 24.6.0: Mon Jul 14 11:30:40 PDT 2025; root:xnu-11417.140.69~1/RELEASE_ARM64_T6041 arm64

If your bug is rendering-related, copy the adapter info that appears when you run Bevy.

` AdapterInfo { name: "Apple M4 Pro", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }`

You should also consider testing the examples of our upstream dependencies to help isolate any setup-specific issue:

• wgpu for rendering problems
• winit for input and window management
• gilrs for gamepad inputs

What you did

cargo run --package bevy --example log_diagnostics

What went wrong

example crashed

when removed RenderDiagnosticsPlugin , log example works again

Additional information

❯ cargo run --package bevy --example log_diagnostics
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.44s
     Running `target/debug/examples/log_diagnostics`
2025-09-23T02:13:58.730602Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "macOS 15.6.1 Sequoia", kernel: "24.6.0", cpu: "Apple M4 Pro", core_count: "14", memory: "48.0 GiB" }
2025-09-23T02:13:58.798930Z  INFO bevy_render::renderer: AdapterInfo { name: "Apple M4 Pro", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
2025-09-23T02:13:59.175018Z  INFO bevy_render::batching::gpu_preprocessing: GPU preprocessing is fully supported on this device.
2025-09-23T02:13:59.203812Z  INFO bevy_winit::system: Creating new window log_diagnostics (0v0)
2025-09-23T02:14:00.154466Z ERROR wgpu::backend::wgpu_core: Handling wgpu errors as fatal by default

thread '<unnamed>' panicked at /Users/zool/.cargo/registry/src/rsproxy.cn-e3de039b2554c837/wgpu-26.0.1/src/backend/wgpu_core.rs:2391:18:
wgpu error: Validation Error

Caused by:
  In a CommandEncoder
    In a pass parameter
      Encoder is invalid


note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `bevy_render::renderer::render_system`!
2025-09-23T02:14:00.287593Z ERROR winit::platform_impl::macos::event_handler: tried to run event handler, but no handler was set

[foxzool]

disable RenderDiagnosticsPlugin , example works

[janhohenheim]

Mind filling out the relevant sections in the issue template or removing them for readability? :)

Does this happen in 0.16 too? If not, I'm moving this to the milestone

[foxzool]

Mind filling out the relevant sections in the issue template or removing them for readability? :)

Does this happen in 0.16 too? If not, I'm moving this to the milestone

0.16 works fine, the issue section has been updated

[janhohenheim]

Added to the milestone because this sounds potentially serious, as it may crash other things than just the fps plugin.
Maintainers, feel free to kick this out again :)

[Rajveer100]

stack backtrace

rajveersingh@MacBook-Pro bevy % RUST_BACKTRACE=1 cargo run --package bevy --example log_diagnostics
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.61s
     Running `target/debug/examples/log_diagnostics`
2025-09-23T11:15:14.694677Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "macOS 26.0", kernel: "25.0.0", cpu: "Apple M1 Pro", core_count: "10", memory: "16.0 GiB" }
2025-09-23T11:15:14.768083Z  INFO bevy_render::renderer: AdapterInfo { name: "Apple M1 Pro", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
2025-09-23T11:15:15.125815Z  INFO bevy_render::batching::gpu_preprocessing: GPU preprocessing is fully supported on this device.
2025-09-23T11:15:15.179852Z  INFO bevy_winit::system: Creating new window log_diagnostics (0v0)
2025-09-23T11:15:17.281445Z ERROR wgpu::backend::wgpu_core: Handling wgpu errors as fatal by default

thread '<unnamed>' panicked at /Users/rajveersingh/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wgpu-26.0.1/src/backend/wgpu_core.rs:2391:18:
wgpu error: Validation Error

Caused by:
  In a CommandEncoder
    In a pass parameter
      Encoder is invalid


stack backtrace:
   0: __rustc::rust_begin_unwind
             at /rustc/29483883eed69d5fb4db01964cdf2af4d86e9cb2/library/std/src/panicking.rs:697:5
   1: core::panicking::panic_fmt
             at /rustc/29483883eed69d5fb4db01964cdf2af4d86e9cb2/library/core/src/panicking.rs:75:14
   2: wgpu::backend::wgpu_core::default_error_handler
             at /Users/rajveersingh/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wgpu-26.0.1/src/backend/wgpu_core.rs:659:5
   3: wgpu::backend::wgpu_core::ErrorSinkRaw::handle_error
             at /Users/rajveersingh/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wgpu-26.0.1/src/backend/wgpu_core.rs:643:21
   4: wgpu::backend::wgpu_core::ContextWgpuCore::handle_error_inner
             at /Users/rajveersingh/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wgpu-26.0.1/src/backend/wgpu_core.rs:298:14
   5: wgpu::backend::wgpu_core::ContextWgpuCore::handle_error_nolabel
             at /Users/rajveersingh/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wgpu-26.0.1/src/backend/wgpu_core.rs:323:14
   6: <wgpu::backend::wgpu_core::CoreCommandEncoder as wgpu::dispatch::CommandEncoderInterface>::finish
             at /Users/rajveersingh/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wgpu-26.0.1/src/backend/wgpu_core.rs:2391:18
   7: wgpu::api::command_encoder::CommandEncoder::finish
             at /Users/rajveersingh/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wgpu-26.0.1/src/api/command_encoder.rs:56:33
   8: bevy_render::renderer::RenderContext::flush_encoder
             at ./crates/bevy_render/src/renderer/mod.rs:650:58
   9: bevy_render::renderer::RenderContext::add_command_buffer_generation_task
             at ./crates/bevy_render/src/renderer/mod.rs:557:14
  10: bevy_pbr::render::light::ShadowPassNode::run
             at ./crates/bevy_pbr/src/render/light.rs:2307:32
  11: <bevy_pbr::render::light::EarlyShadowPassNode as bevy_render::render_graph::node::Node>::run
             at ./crates/bevy_pbr/src/render/light.rs:2242:16
  12: bevy_render::renderer::graph_runner::RenderGraphRunner::run_graph
             at ./crates/bevy_render/src/renderer/graph_runner.rs:224:37
  13: bevy_render::renderer::graph_runner::RenderGraphRunner::run_graph
             at ./crates/bevy_render/src/renderer/graph_runner.rs:231:21
  14: bevy_render::renderer::graph_runner::RenderGraphRunner::run
             at ./crates/bevy_render/src/renderer/graph_runner.rs:79:9
  15: bevy_render::renderer::render_system
             at ./crates/bevy_render/src/renderer/mod.rs:42:15
  16: core::ops::function::FnMut::call_mut
             at /Users/rajveersingh/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:166:5
  17: core::ops::function::impls::<impl core::ops::function::FnMut<A> for &mut F>::call_mut
             at /Users/rajveersingh/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:294:21
  18: <Func as bevy_ecs::system::exclusive_function_system::ExclusiveSystemParamFunction<fn(F0) .> Out>>::run::call_inner
             at ./crates/bevy_ecs/src/system/exclusive_function_system.rs:270:21
  19: <Func as bevy_ecs::system::exclusive_function_system::ExclusiveSystemParamFunction<fn(F0) .> Out>>::run
             at ./crates/bevy_ecs/src/system/exclusive_function_system.rs:273:17
  20: <bevy_ecs::system::exclusive_function_system::ExclusiveFunctionSystem<Marker,Out,F> as bevy_ecs::system::system::System>::run_unsafe::{{closure}}
             at ./crates/bevy_ecs/src/system/exclusive_function_system.rs:135:33
  21: bevy_ecs::world::World::last_change_tick_scope
             at ./crates/bevy_ecs/src/world/mod.rs:2998:9
  22: <bevy_ecs::system::exclusive_function_system::ExclusiveFunctionSystem<Marker,Out,F> as bevy_ecs::system::system::System>::run_unsafe
             at ./crates/bevy_ecs/src/system/exclusive_function_system.rs:113:15
  23: bevy_ecs::system::system::System::run_without_applying_deferred
             at ./crates/bevy_ecs/src/system/system.rs:139:23
  24: bevy_ecs::system::system::System::run
             at ./crates/bevy_ecs/src/system/system.rs:119:24
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Encountered a panic in system `bevy_render::renderer::render_system`!
2025-09-23T11:15:17.786579Z  INFO bevy_diagnostic: system/cpu_usage :   23.423632%  (avg 27.213439%)
2025-09-23T11:15:17.786618Z  INFO bevy_diagnostic: frame_time       : 1986.355250ms (avg 1269.634604ms)
2025-09-23T11:15:17.786625Z  INFO bevy_diagnostic: process/cpu_usage:    0.000000%  (avg 0.000000%)
2025-09-23T11:15:17.786631Z  INFO bevy_diagnostic: entity_count     :   32.000000   (avg 27.000000)
2025-09-23T11:15:17.786639Z  INFO bevy_diagnostic: system/mem_usage :   76.098633%  (avg 76.438141%)
2025-09-23T11:15:17.786645Z  INFO bevy_diagnostic: fps              :    0.503435   (avg 1.156017)
2025-09-23T11:15:17.786650Z  INFO bevy_diagnostic: frame_count      : 2.000000
2025-09-23T11:15:17.786655Z  INFO bevy_diagnostic: process/mem_usage:    0.000000GiB (avg 0.000000GiB)

I think this is related to wgpu rather than bevy itself?

    fn flush_encoder(&mut self) {
        if let Some(encoder) = self.command_encoder.take() {
            self.command_buffer_queue
                .push(QueuedCommandBuffer::Ready(encoder.finish())); // <<<<<<< .finish()
        }
    }