Add version field to 27 local-sourced plugins#1050
Open
dicksontsai wants to merge 1 commit intomainfrom
Open
Conversation
Local-path plugins (source is a string like "./plugins/foo" in
marketplace.json) without a manifest version cache at
~/.claude/plugins/cache/{marketplace}/{plugin}/unknown/ forever.
The cache check in claude-cli's copyPluginToVersionedCache sees
pathExists(.../unknown/) → true → skips re-extraction, even after
the marketplace content updates. Users are stuck with stale plugin
files until they manually delete the cache.
Adding "version": "1.0.0" fixes this because calculatePluginVersion
reads the manifest from the freshly-synced marketplace tree (not the
stale cache), and manifest.version is priority #1 in version
resolution. New version → new cache path → cache miss → re-extract.
This is preferable to the GCS-SHA fallback approach
(anthropics/claude-cli-internal#24773) because:
- Per-plugin granularity: only bumped plugins re-extract, not all
27 on every marketplace push
- No disk accumulation from unrelated marketplace churn
- Fixes both the runtime loader path AND the migration path
(manifest.version is priority #1 in both)
- No claude-cli code change needed
Remote-sourced plugins (github/git/url) already get a git SHA as
their version and are unaffected.
fatcatMaoFei
pushed a commit
to fatcatMaoFei/claude-plugins-official
that referenced
this pull request
Mar 29, 2026
Complements anthropics#1050 which covers 27 plugins. These 3 were missed: - external_plugins/slack - plugins/example-plugin - plugins/math-olympiad
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
27 local-path plugins (where
sourceis a string like"./plugins/foo"in marketplace.json) have noversionfield in their.claude-plugin/plugin.json. This causes claude-cli to cache them at~/.claude/plugins/cache/{marketplace}/{plugin}/unknown/forever.The cache check in
copyPluginToVersionedCache(pluginLoader.ts) seespathExists(.../unknown/)→ true → skips re-extraction, even after the marketplace content updates. Users are stuck with stale plugin files until they manually delete the cache. This is currently blocking the exec-bit preservation fix from reaching users with already-cached 644 hook scripts.Fix
Add
"version": "1.0.0"to all 27 affected manifests.This works because
calculatePluginVersionreads the manifest from the freshly-synced marketplace tree (not the stale cache), andmanifest.versionis priority #1 in version resolution. New version → new cache path → cache miss → re-extract.Why this instead of anthropics/claude-cli-internal#24773 (GCS SHA fallback)
migrateFromEnabledPlugins; runtimecalculatePluginVersionstill returns'unknown'The marketplace updates far more often than any individual plugin — using the marketplace SHA as a per-plugin cache key is the wrong granularity.
Affected plugins
plugins/ (15): agent-sdk-dev, code-review, commit-commands, explanatory-output-style, feature-dev, frontend-design, hookify, learning-output-style, mcp-server-dev, playground, plugin-dev, pr-review-toolkit, ralph-loop, security-guidance, skill-creator
external_plugins/ (12): asana, context7, firebase, github, gitlab, greptile, laravel-boost, linear, playwright, serena, supabase, terraform
Remote-sourced plugins (github/git/url in marketplace.json) already get a git SHA version and are unaffected.
Follow-up (not in this PR)
autofix-bothave no manifest at all — separate issue