fix: invoke .sh hooks via bash prefix (fixes #993)#1115
Merged
dicksontsai merged 1 commit intomainfrom Mar 29, 2026
Merged
Conversation
…tion Fixes #993 (Permission denied on hook scripts) without relying on client-side +x preservation. The hook executor spawns commands via /bin/sh -c, which requires +x to execute a script directly. Prefixing with bash reads the script as data — mode bits are irrelevant. This works on all Claude Code versions, whereas the client-side chmod fix (claude-cli #24666) only shipped in v2.1.86. All 3 scripts declare #!/bin/bash and use bashisms ([[ ]], =~), so bash (not sh) is the correct interpreter. The version field forces a fresh cache path (1.0.0/ instead of unknown/), ensuring the new hooks.json reaches users with stale caches.
sid374
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hook scripts in
ralph-loop,explanatory-output-style, andlearning-output-stylefail withPermission deniedwhen the.shfile lacks +x (#993).Fix
Two changes per plugin:
hooks.json: prefix withbashso the script is read as data, not exec'd:Mode bits are now irrelevant.
plugin.json: add"version": "1.0.0"to invalidate theunknown/cache —calculatePluginVersionreads the manifest from the freshly-synced marketplace tree, so the new version forces a new cache path and re-extraction.Why
bash, notsh?All 3 scripts declare
#!/bin/bashand use bashisms ([[ ]],=~regex) that POSIXsh(dash/ash) can't run. Usingshwould break them on Debian/Alpine where/bin/sh≠ bash.