Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings #37

Open
wants to merge 6 commits into
base: 10.0
Choose a base branch
from
Open

Add settings #37

wants to merge 6 commits into from

Conversation

hparfr
Copy link
Member

@hparfr hparfr commented Dec 10, 2018

In order to specify stuff like facetting

In ordre to specify stuff like facetting
@coveralls
Copy link

coveralls commented Dec 10, 2018

Coverage Status

Coverage decreased (-5.3%) to 80.858% when pulling 8825b56 on 10.0-add_settings into 1ffa7af on 10.0.

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #37 into 10.0 will decrease coverage by 5.27%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             10.0      #37      +/-   ##
==========================================
- Coverage   86.13%   80.85%   -5.28%     
==========================================
  Files          12       12              
  Lines         274      303      +29     
==========================================
+ Hits          236      245       +9     
- Misses         38       58      +20
Impacted Files Coverage Δ
connector_search_engine/models/se_binding.py 93.02% <ø> (ø) ⬆️
connector_search_engine/models/se_index.py 73.4% <22.22%> (-5.42%) ⬇️
connector_algolia/components/adapter.py 63.63% <38.09%> (-18.51%) ⬇️
connector_search_engine/components/adapter.py 66.66% <50%> (-2.57%) ⬇️
connector_search_engine/components/exporter.py 92.85% <50%> (-7.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ffa7af...8825b56. Read the comment docs.

@sebastienbeau
Copy link
Member

I do not think that we should use a text field but instead generating this data, as it can be define with data with have in odoo

@hparfr
Copy link
Member Author

hparfr commented Dec 10, 2018

It can be used to store everything index related in Algolia, like searchable attributes, facetting, and more https://www.algolia.com/doc/api-reference/settings-api-parameters/

I agree facetting management can be done with more user friendliness but let's start with this and improve it later.

@@ -56,6 +56,7 @@ Contributors

* Sébastien BEAU <[email protected]>
* Laurent Mignon <[email protected]>
* Raphaël Reverdy <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use readme fragments

@sebastienbeau
Copy link
Member

I agree that we should not do everything yet, doing the minimal is better then nothing. But maybe it will be better to think how this will work in a long term and just implement the minimal right way.
For now I am more in favor of using a method that return the configuration, instead of making it available in a setting, but we need to disuse about it this morning

Copy link
Member

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to discus

@florian-dacosta
Copy link
Member

@hparfr @sebastienbeau
What do you think?
Some remarks :
In order to export setting (only facetting for now), I use the same adapter/exporter as to export the binding, but I wonder if I should not create a new adapter/exporter for this. I am not sure it is worth it though... Or just a new exporter, that would use the same adapter, let me know what you think.

Also, I did some refactore in algolia adapter, I did it in a separate commit, case it is not acceptable we can revert it easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants