-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings #37
base: 10.0
Are you sure you want to change the base?
Add settings #37
Conversation
In ordre to specify stuff like facetting
Codecov Report
@@ Coverage Diff @@
## 10.0 #37 +/- ##
==========================================
- Coverage 86.13% 80.85% -5.28%
==========================================
Files 12 12
Lines 274 303 +29
==========================================
+ Hits 236 245 +9
- Misses 38 58 +20
Continue to review full report at Codecov.
|
I do not think that we should use a text field but instead generating this data, as it can be define with data with have in odoo |
It can be used to store everything index related in Algolia, like searchable attributes, facetting, and more https://www.algolia.com/doc/api-reference/settings-api-parameters/ I agree facetting management can be done with more user friendliness but let's start with this and improve it later. |
@@ -56,6 +56,7 @@ Contributors | |||
|
|||
* Sébastien BEAU <[email protected]> | |||
* Laurent Mignon <[email protected]> | |||
* Raphaël Reverdy <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use readme fragments
I agree that we should not do everything yet, doing the minimal is better then nothing. But maybe it will be better to think how this will work in a long term and just implement the minimal right way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to discus
0ff08c2
to
5561a35
Compare
@hparfr @sebastienbeau Also, I did some refactore in algolia adapter, I did it in a separate commit, case it is not acceptable we can revert it easily. |
f281e56
to
8825b56
Compare
In order to specify stuff like facetting