WIP Export facetting setting to algolia #270
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace https://github.com/akretion/odoo-shopinvader/pull/250
Depends on akretion/connector-search-engine#37
Also, it still misses one feature.
We should export settings at 2 moment:
I wonder where I should do the second export.
I think I could do it in method
_jobify_batch_export
because it is called both by daily export binding cron and the button at backend level.If I do it there, should I do it in a job, to avoid to make the batch export job to fail if we fail to export the setting, or is it ok?
If the user do an export directly from the binding, it won't do the check either, but I do not think it is an issue, I guess the first export of the index should be done directly from the se backend or from the cron.
Any ideal about this?
@hparfr @sebastienbeau