Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Export facetting setting to algolia #270

Closed
wants to merge 1 commit into from

Conversation

florian-dacosta
Copy link
Contributor

replace https://github.com/akretion/odoo-shopinvader/pull/250
Depends on akretion/connector-search-engine#37

Also, it still misses one feature.
We should export settings at 2 moment:

  1. by cron, once a day, we force the setting export (already implemented)
  2. At the first index creation (not implemented yet)
    I wonder where I should do the second export.
    I think I could do it in method _jobify_batch_export because it is called both by daily export binding cron and the button at backend level.
    If I do it there, should I do it in a job, to avoid to make the batch export job to fail if we fail to export the setting, or is it ok?
    If the user do an export directly from the binding, it won't do the check either, but I do not think it is an issue, I guess the first export of the index should be done directly from the se backend or from the cron.

Any ideal about this?

@hparfr @sebastienbeau

@coveralls
Copy link

Coverage Status

Coverage decreased (-35.4%) to 53.145% when pulling a4711be on 10.0-expot-settings-algolia into 7ff4731 on 10.0.

@simahawk
Copy link
Contributor

has been done here for v12 #395
I close this as there's no activity since almost one year: feel free to reopen if needed (but then have a look at v12 😉 )

@simahawk simahawk closed this Nov 29, 2019
@hparfr hparfr deleted the 10.0-expot-settings-algolia branch April 20, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants