Refactore settings export management

Author: florian-dacosta

connector_algolia/components/adapter.py

@@ -32,12 +32,16 @@ def _get_index(self):
             backend.algolia_app_id, account._get_password())
         return client.initIndex(self.work.index.name)
 
-    def _set_settings(self, index):
+    def set_settings(self, force=True):
         """Set advanced settings like facettings attributes."""
-        data = self.work.index.settings
-        if data:
-            clean = json.loads(data)
-            index.setSettings(clean)
+        set_settings = force
+        index = self._get_index()
+        data = self.work.index._get_setting_values()
+        if not force:
+            settings = index.get_settings()
+            set_settings = not settings and True or False
+        if data and set_settings:
+            index.setSettings(data)
 
     def index(self, datas):
         index = self._get_index()
@@ -47,7 +51,6 @@ def index(self, datas):
             if not data.get('objectID'):
                 raise UserError(
                     _('The key objectID is missing in the data %s') % data)
-        self._set_settings(index)
         index.add_objects(datas)
 
     def delete(self, binding_ids):
@@ -57,4 +60,4 @@ def delete(self, binding_ids):
     def clear(self):
         index = self._get_index()
         index.clear_index()
-        self._set_settings(index)
+        self.set_settings()

connector_search_engine/components/adapter.py

@@ -23,3 +23,7 @@ def delete(self, binding_ids):
 
     def clear(self):
         return NotImplemented
+
+    def set_settings(self, force=True):
+        """Set advanced settings like facettings attributes."""
+        return NotImplemented

connector_search_engine/components/exporter.py

@@ -21,3 +21,7 @@ def run(self):
         """ Run the synchronization """
         self.work.records.write({'sync_state': 'done'})
         return self._index([record.data for record in self.work.records])
+
+    def export_settings(self, force=True):
+        """ Run the settings synchronization """
+        return self.backend_adapter.set_settings(force=force)

connector_search_engine/data/ir_cron.xml

@@ -27,4 +27,17 @@
         <field eval="'()'" name="args"/>
     </record>
 
+    <record forcecreate="True" id="ir_cron_export_settings" model="ir.cron">
+        <field name="name">Search engine: Export settings for all indexes</field>
+        <field eval="False" name="active"/>
+        <field name="user_id" ref="base.user_root"/>
+        <field name="interval_number">1</field>
+        <field name="interval_type">days</field>
+        <field name="numbercall">-1</field>
+        <field eval="False" name="doall"/>
+        <field eval="'se.index'" name="model"/>
+        <field eval="'export_all_settings'" name="function"/>
+        <field eval="'()'" name="args"/>
+    </record>
+
 </odoo>

connector_search_engine/models/se_index.py

@@ -46,9 +46,6 @@ def _get_model_domain(self):
         string='Model',
         required=True,
         domain=_get_model_domain)
-    settings = fields.Text(
-        'Additionnal settings',
-        help="Facetting, pagination, advanced settings, etc.")
     exporter_id = fields.Many2one(
         'ir.exports',
         string='Exporter')
@@ -143,3 +140,21 @@ def clear_index(self):
             adapter = work.component(usage='se.backend.adapter')
             adapter.clear()
         return True
+
+    def _get_setting_values(self):
+        """
+            Override this method is sub modules in order to pass the adequate
+            settings (like Facetting, pagination, advanced settings, etc...)
+        """
+        self.ensure_one()
+        return {}
+
+    @api.model
+    def export_all_settings(self):
+        for index in self.search([]):
+            se_specific_backend = index.backend_id.specific_backend
+            with se_specific_backend.work_on(
+                index.model_id.model, index=index
+            ) as work:
+                exporter = work.component(usage='se.record.exporter')
+                exporter.export_settings()