(feat-redraw)Add curated label2 node subtitles (event_v1 1.1.0)#663
Merged
Conversation
This was referenced Jun 23, 2026
pregnor
previously approved these changes
Jun 24, 2026
misi-bp
previously approved these changes
Jun 26, 2026
delthazor
force-pushed
the
rework-dynamic-graph-drawing5
branch
from
dd8a841 to
e8797e3
Compare
delthazor
dismissed stale reviews from misi-bp and pregnor
The base branch was changed.
The group container only ever served as a faint background box. Hide it (hidden: true) so it is never rendered, while keeping it in the topology so children still resolve parentId/extent. Dimensions move from style to top-level width/height because extent clamping reads node.width when a node is hidden (never measured), otherwise children collapse to origin. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: pdobrei <pdobrei@cisco.com>
Since the logistics group became a hidden layout anchor, the code that
only existed to draw/size a visible group box is now dead:
- delete the unused topologyGroupLayout.ts module (stale duplicate of
layoutCompactGroup)
- write the fitted group size to the node's top-level width/height (what
extent clamping reads) instead of the moot style write
- drop the dead "logistics-group" branch in nodeSlugKey (the group has no
edges and is never an author alias)
- shrink the group node data to {} in both renderers (never displayed)
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: pdobrei <pdobrei@cisco.com>
Add an optional label2 field to event_v1 partial_regular_node and bump the schema to 1.1.0 (minor, backward compatible) so curated two-line node labels survive the backend-driven render instead of being heuristically split. The frontend honors wire.label2 when present and falls back to splitTopologyNodeLabel for older minors and discovered agents. Seed the five curated pairs in starting_workflows.json, and dump the seed topology with exclude_none so the new optional field never serializes as null and trips schema validation. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: pdobrei <pdobrei@cisco.com>
Label 2 has been renamed to label_subtitle, therefore label1 can be referenced as label from now. Signed-off-by: pdobrei <pdobrei@cisco.com>
A new file was added that still uses the old label naming. Adjusting that to accomodate this label naming change. Signed-off-by: pdobrei <pdobrei@cisco.com>
delthazor
force-pushed
the
rework-dynamic-graph-drawing6
branch
from
f3b87d1 to
2e5d3da
Compare
misi-bp
approved these changes
Jul 7, 2026
pregnor
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an optional label2 field to event_v1 partial_regular_node and bump the schema to 1.1.0 (minor, backward compatible) so curated two-line node labels survive the backend-driven render instead of being heuristically split. The frontend honors wire.label2 when present and falls back to splitTopologyNodeLabel for older minors and discovered agents. Seed the five curated pairs in starting_workflows.json, and dump the seed topology with exclude_none so the new optional field never serializes as null and trips schema validation.
Topology graphs should be rendered dynamically based on backend provided data. This was partially done before, but was mostly reverted, due to stylistic and structural reasons, e.g.: specific icons were not rendered correctly, nodes not appearing as they should, etc.
This change aims to correct node labeling by introducing proper two-part label system, just like in the statically defined nodes.
This PR is not a standalone change, it is a part of a chain of smaller changes reviewed independently.
The previous PR, this one immediately depends on:
#661
The dynamic graph rendering change, that this PR logically depends on:
#657
The follow-up PR is here:
This supposed to be the last PR regarding graph rendering and dynamic drawing.
However, the properly implemented changes allows us te clean up previously used, but no longer necessary static maps, which were used to define detailed data for the nodes.
The cleanup is a separate changes, starting with this PR:
#586
Other corresponding PRs:
#656
#658
#659
Issue Link
No specific issue was opened for the change.
Type of Change
Checklist