(feat-redraw)Update animation handling#661
Merged
Merged
Conversation
This was referenced Jun 23, 2026
mihaialexandrescu
previously approved these changes
Jun 25, 2026
misi-bp
reviewed
Jun 29, 2026
misi-bp
previously approved these changes
Jun 29, 2026
misi-bp
left a comment
misi-bp
left a comment
Contributor
There was a problem hiding this comment.
I left a single comment here with a nice to have recommendation.
The whole utils folder will be reorganized soon so that's why it is not urgent to fix it now. Up 2 U.
Base automatically changed from
rework-dynamic-graph-drawing4
to
rework-dynamic-graph-drawing3
July 2, 2026 07:55
delthazor
force-pushed
the
rework-dynamic-graph-drawing3
branch
from
bb87f3d to
26a831f
Compare
delthazor
dismissed stale reviews from misi-bp and mihaialexandrescu
The base branch was changed.
The group container only ever served as a faint background box. Hide it (hidden: true) so it is never rendered, while keeping it in the topology so children still resolve parentId/extent. Dimensions move from style to top-level width/height because extent clamping reads node.width when a node is hidden (never measured), otherwise children collapse to origin. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: pdobrei <pdobrei@cisco.com>
Since the logistics group became a hidden layout anchor, the code that
only existed to draw/size a visible group box is now dead:
- delete the unused topologyGroupLayout.ts module (stale duplicate of
layoutCompactGroup)
- write the fitted group size to the node's top-level width/height (what
extent clamping reads) instead of the moot style write
- drop the dead "logistics-group" branch in nodeSlugKey (the group has no
edges and is never an author alias)
- shrink the group node data to {} in both renderers (never displayed)
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: pdobrei <pdobrei@cisco.com>
Re-enable the button-click pulse in agentic mode, driving it from the live graph via selectAnimationSequence/deriveAnimationSequenceFromGraph instead of the static authored sequence, so pulses target real backend node/edge ids. The BFS derivation now also pulses re-entrant fan-in / back-to-source edges so no edge that the static sequence animated goes missing, while still scheduling each node once to terminate. The latest graph snapshot is read from refs at animation start to avoid re-triggering mid-pulse. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: pdobrei <pdobrei@cisco.com>
Recruiter had some issues to assign correct advertised URL-s to discovered agents, and timeout through JSONRPC was way too common. Also unnecessary middleware nodes were appearing during communication, which are now hidden. Signed-off-by: pdobrei <pdobrei@cisco.com>
delthazor
force-pushed
the
rework-dynamic-graph-drawing5
branch
from
dd8a841 to
e8797e3
Compare
pregnor
previously approved these changes
Jul 6, 2026
pregnor
left a comment
pregnor
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but get an approval from Misi on the FE stuff.
Loose specifications causes. CI test runs to fail on incorrect agent card tests. Made that stricter, so exact requirements are plain, and tests follows them. Signed-off-by: pdobrei <pdobrei@cisco.com>
pregnor
approved these changes
Jul 7, 2026
misi-bp
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-enable the button-click pulse in agentic mode, driving it from the live graph via selectAnimationSequence/deriveAnimationSequenceFromGraph instead of the static authored sequence, so pulses target real backend node/edge ids. The BFS derivation now also pulses re-entrant fan-in / back-to-source edges so no edge that the static sequence animated goes missing, while still scheduling each node once to terminate. The latest graph snapshot is read from refs at animation start to avoid re-triggering mid-pulse.
Topology graphs should be rendered dynamically based on backend provided data. This was partially done before, but was mostly reverted, due to stylistic and structural reasons, e.g.: specific icons were not rendered correctly, nodes not appearing as they should, etc.
This change aims to make animations and highlights in sync with the original statically defined sequences.
This PR is not a standalone change, it is a part of a chain of smaller changes reviewed independently.
The previous PR, this one immediately depends on:
#659
The dynamic graph rendering change, that this PR logically depends on:
#657
The follow-up PR is here:
#663
Other corresponding PRs:
#656
#658
Issue Link
No specific issue was opened for the change.
Type of Change
Checklist