Skip to content

(feat-redraw)MVP for dynamic graph rendering with feature parity#657

Merged
delthazor merged 4 commits into
mainfrom
rework-dynamic-graph-drawing2
Jul 1, 2026
Merged

(feat-redraw)MVP for dynamic graph rendering with feature parity#657
delthazor merged 4 commits into
mainfrom
rework-dynamic-graph-drawing2

Conversation

@delthazor

@delthazor delthazor commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

Replaces the statically defined graph drawing with a dynamic, backend data driven one.
The change contains extra changes to reach minimal feature parity for animations, test coverage, and A2A representation of SSE processing.

Topology graphs should be rendered dynamically based on backend provided data. This was partially done before, but was mostly reverted, due to stylistic and structural reasons, e.g.: specific icons were not rendered correctly, nodes not appearing as they should, etc.

This change aims to (re-)introduce the MVP version of the backend-driven dynamic graph rendering, this time with feature parity, and correct representation. For this, a previous PR already defines necessary node data resolvers the current code aims to use for the required graph representation quality.

This PR is not a standalone change, it is a part of a chain of smaller changes reviewed independently.

The previous PR, this one immediately depends on:
#656

The follow-up PR is here:
#658

Other corresponding PRs:
#659
#661
#663

Issue Link

No specific issue was opened for the change.

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

delthazor and others added 4 commits June 23, 2026 09:47
Remove the static-id-map early return so the agentic graph always renders
from backend topology: always apply and refetch on SSE, highlight only in
the dynamic React Flow id namespace, and patch transport-name labels on
dynamic nodes/edges via the new dynamicTransportLabels helper.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: pdobrei <pdobrei@cisco.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve recruiter/directory stream authors and the auction animation
sequence through a canonical node slug (getOasfSlugFromNodeData) so chat
highlighting targets live API-driven ids instead of authored NODE_IDS/
EDGE_IDS. useMainArea now translates the static animation sequence to live
ids when the graph is API-owned; feeds remain unchanged.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: pdobrei <pdobrei@cisco.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
The static id map is unused since the renderer switched to live API
topology; full static-config/NODE_IDS teardown is deferred pending the
non-agentic fallback and discovery-overlay decisions.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: pdobrei <pdobrei@cisco.com>
…ream highlight

Use isDirectoryLabel from agenticTopologyIdentityUiMap in nodeSlugKey
instead of the inlined agntcy/agent-directory heuristic, completing the
label-predicate centralization for the live chat-stream highlight path.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: pdobrei <pdobrei@cisco.com>
@delthazor delthazor self-assigned this Jun 23, 2026
@delthazor delthazor added the enhancement New feature or request label Jun 23, 2026
@delthazor delthazor changed the title MVP for dynamic graph rendering with feature parity (feat-redraw)MVP for dynamic graph rendering with feature parity Jun 23, 2026
@delthazor delthazor marked this pull request as ready for review June 23, 2026 12:17
@delthazor delthazor requested a review from a team as a code owner June 23, 2026 12:17
pregnor
pregnor previously approved these changes Jun 24, 2026

@pregnor pregnor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a quick glance, get @misi-bp 's approval.

@misi-bp misi-bp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

misi-bp
misi-bp previously approved these changes Jun 26, 2026

@misi-bp misi-bp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from rework-dynamic-graph-drawing to main July 1, 2026 09:56
@delthazor delthazor dismissed stale reviews from mihaialexandrescu, misi-bp, and pregnor July 1, 2026 09:56

The base branch was changed.

@delthazor delthazor merged commit a6d44ab into main Jul 1, 2026
19 checks passed
@delthazor delthazor deleted the rework-dynamic-graph-drawing2 branch July 1, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants