Paper metadata process clarifications #6518
Conversation
|
Build successful. Some useful links:
This preview will be removed when the branch is merged. |
hugo/layouts/papers/single.html
Outdated
| <label class="form-check-label" for="pdfCorrectionCheck">ALL author names match the snapshot above—including middle initials, hyphens, and accents.</label> | ||
| </div> | ||
| <button type="button" class="btn btn-primary" onclick="submitMetadataCorrection()">Submit</button> | ||
| <button type="button" class="btn btn-primary" onclick="submitMetadataCorrection()">Submit as a GitHub issue for staff review</button> |
There was a problem hiding this comment.
I feel the button looks quite bulky with that much text. Maybe just “Submit for staff review”?
There was a problem hiding this comment.
I don't mind the bulkiness if it may prevent confusion. @mjpost what do you think?
There was a problem hiding this comment.
...it is ugly, but I also think we should err on the side of providing information.
I wonder if any people fail to submit the issue on Github. Should we have it read "Create Github Issue" (optionally with "for staff review" on second line)?
There was a problem hiding this comment.
|
I was actually thinking of expanding the bot response, with the same purpose. Currently we say:
Maybe this could become something like this:
|
nschneid
changed the title
|
^ implemented |
|
I'm happy with the improvements. Does someone want to approve? |
| <div class="mb-3"> | ||
| Use this form to create a GitHub issue with structured data describing the correction. You will need a GitHub account. | ||
| Once you create that issue, the correction will be reviewed by a staff member. | ||
| </div> |
There was a problem hiding this comment.
I wonder if we should add that this form currently does not appear to work with the Github Mobile app.
There was a problem hiding this comment.
https://github.com/orgs/community/discussions/118586
Is there a way to detect that they are on mobile, so as not to clutter the dialog for everybody?
There was a problem hiding this comment.
Not sure if I would introduce a JavaScript component for a rather imprecise heuristic, but I can have a look.
There was a problem hiding this comment.
Might be doable with CSS (display a warning banner only on narrow screens)
There was a problem hiding this comment.
"
There was a problem hiding this comment.
Might be doable with CSS (display a warning banner only on narrow screens)
In Bootstrap 4, the d-lg-none class hides an element (display: none) for large displays.
There was a problem hiding this comment.
OK, the mobile banner is working in the preview: https://preview.aclanthology.org/nschneid-submit-button/2025.cl-1.3/
|
I think this is ready to merge but it needs a review. @mjpost @mbollmann |
I am noticing many people submitting corrections appear confused about the process, either submitting the same request in multiple issues or submitting and then closing the issue. This is an attempt to clarify what happens so it is clear that (i) the process happens on GitHub and (ii) the change is not enacted immediately, but needs to be reviewed.