Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/annotate-metadata-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ jobs:

Please edit the JSON above if it does not match the image.

A staff member will review this correction. Once approved, it will be processed as part of a weekly batch of corrections.
A staff member will review this correction.
- Once approved, it can take 1–2 weeks for this change to be processed as part of a batch of corrections.
- Please **leave this issue open** until it is processed by us.
- Once the issue is closed by us as “resolved”, it will take 30–40 minutes for the correction to appear on the website.
`;

await github.rest.issues.createComment({
Expand Down
11 changes: 9 additions & 2 deletions hugo/layouts/papers/single.html
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,13 @@ <h5 class="modal-title">Correct Metadata for <span id="paperIdSpan"></span></h5>
</div>
<div class="modal-body">
<form id="metadataForm">
<div class="mb-3">
Use this form to create a GitHub issue with structured data describing the correction. You will need a GitHub account.
Once you create that issue, the correction will be reviewed by a staff member.
</div>
Comment on lines +384 to +387
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should add that this form currently does not appear to work with the Github Mobile app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/orgs/community/discussions/118586

Is there a way to detect that they are on mobile, so as not to clutter the dialog for everybody?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I would introduce a JavaScript component for a rather imprecise heuristic, but I can have a look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be doable with CSS (display a warning banner only on narrow screens)

Copy link
Contributor Author

@nschneid nschneid Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"⚠️ Mobile Users: Please note that submitting this form to create a new issue will only work with github.com, not the GitHub Mobile app."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be doable with CSS (display a warning banner only on narrow screens)

In Bootstrap 4, the d-lg-none class hides an element (display: none) for large displays.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the mobile banner is working in the preview: https://preview.aclanthology.org/nschneid-submit-button/2025.cl-1.3/

<div class="alert alert-danger d-lg-none">
⚠️ Mobile Users: Submitting this form to create a new issue will only work with github.com, not the GitHub Mobile app.
</div>
<div class="alert alert-warning" role="alert">
<b>Important</b>: The Anthology treat PDFs as authoritative. Please use this form only to correct data that is out of line with the PDF. See <a href="https://aclanthology.org/info/corrections/">our corrections guidelines</a> if you need to change the PDF.
</div>
Expand All @@ -396,7 +403,7 @@ <h5 class="modal-title">Correct Metadata for <span id="paperIdSpan"></span></h5>

<div class="mb-3">
<label for="paperAbstract" class="form-label">Abstract</label>
<small id="abstractTitleHelp" class="form-text text-muted">Correct abstract if needed. Retain XML formatting tags such as &lt;tex-math&gt;.</small>
<small id="abstractTitleHelp" class="form-text text-muted">Correct abstract if needed. Retain XML formatting tags such as &lt;tex-math&gt;. You may use &lt;b&gt;...&lt;/b&gt; for <b>bold</b>, &lt;i&gt;...&lt;/i&gt; for <i>italic</i>, and &lt;url&gt;...&lt;/url&gt; for URLs.</small>
<textarea class="form-control" id="paperAbstract" rows="6"></textarea>
</div>

Expand All @@ -416,7 +423,7 @@ <h5 class="modal-title">Correct Metadata for <span id="paperIdSpan"></span></h5>
<input type="checkbox" class="form-check-input" id="pdfCorrectionCheck">
<label class="form-check-label" for="pdfCorrectionCheck">ALL author names match the snapshot above—including middle initials, hyphens, and accents.</label>
</div>
<button type="button" class="btn btn-primary" onclick="submitMetadataCorrection()">Submit</button>
<button type="button" class="btn btn-primary" onclick="submitMetadataCorrection()">Create GitHub issue for&nbsp;staff review</button>
</div>
</div>
</div>
Expand Down