Skip to content

Conversation

@MaximeBICMTL
Copy link
Contributor

@MaximeBICMTL MaximeBICMTL commented Dec 5, 2025

During testing of #1338, @jeffersoncasimir found a bug where the EEG chunks path is incorrectly set in the database if the configuration variable EEGChunksPath is used.

After investigation, I also managed to reproduce this bug both on the PR branch and on the 27-release branch (see the screen below). This PR fixes the bug in the main branch by making the code works for both whether EEGChunksPath is set or not. This PR will also need to be backported to 27-release.

image

@github-actions github-actions bot added the Language: Python Issue or PR related to the Python codebase label Dec 5, 2025
@MaximeBICMTL MaximeBICMTL added Category: Bug Issue or PR that aims to report or fix a bug Pipeline: BIDS importer PR or issue related to the BIDS importer labels Dec 5, 2025
@MaximeBICMTL MaximeBICMTL changed the title Fix EEG chunks path bug with EEGChunksPath in EEG BIDS Import Fix EEG chunks path bug with EEGChunksPath in EEG BIDS import Dec 5, 2025
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great!

Fixes the issues with #1338

Ready to merge

@MaximeBICMTL MaximeBICMTL changed the base branch from main to maxime_changes December 22, 2025 09:06
@MaximeBICMTL MaximeBICMTL added this to the 28.0.0 milestone Dec 22, 2025
@MaximeBICMTL MaximeBICMTL merged commit a8aaf76 into maxime_changes Dec 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Bug Issue or PR that aims to report or fix a bug Language: Python Issue or PR related to the Python codebase Pipeline: BIDS importer PR or issue related to the BIDS importer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants