Fix EEG chunks path bug with EEGChunksPath in EEG BIDS import (27 release) #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language: Python
MaximeBICMTL
added
the
Category: Bug
MaximeBICMTL
force-pushed
the
fix_eeg_path_bug_27
branch
from
c39cc18 to
c5b86e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #1345 and #1343 (only the bug fix part) for 27 release
The code of the first fix is slightly different because the newer version of the code uses
os.path, whereas the 27 release version uses string operations.Tested the PR manually with
EEGChunksPathboth set and not set.The integration tests for this PR do not pass yet as we still did not fix the 27 release dependencies versions, but that is unrelated to this PR.