-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with POSIX shell in SRM (ash) #5570
Conversation
Alternatively if this approach is too hackey we could use a token character to separate multiple SERVICE_COMMANDs e.g. |
@publicarray what about the |
Thanks @hgy59 I'll take a look |
I think using |
@publicarray you are right. The As I already did a redesign to allow special characters in such variables (#5430) there is a conflict that must be resolved. Finally PR #5555 can benefit of the new function |
- rename reload_inst_variables to load_variables_from_file with parameter - make spksrc.service.installer.functions compatible with sh/ash
Description
Rather than using arrays I'm using the newline character for separation, it is more hacky but should still work.
I still need to test if deluge works with this.I have confirmed that Cloudflared works with this change on the SRM.Fixes #5548
Checklist
all-supported
completed successfullyType of change