Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: fix installer, add arch vars #5602

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Framework: fix installer, add arch vars #5602

merged 2 commits into from
Feb 12, 2023
+43 −8

Conversation

mreid-tt
Copy link
Contributor

@mreid-tt mreid-tt commented Feb 12, 2023 •
edited
Loading

Description

These changes to the framework were motivated by (a) install errors with the load_variables_from_file function (b) inconsistent arch exclusions for dotnet packages. This PR contains the following:

  1. Fixes bug in call_func arguments used by load_variables_from_file function
  2. Add Makefile variables for dotnet 6.0 arch exclusions (core and servarr)

Follow up of #5570
Fixes #5574 (adds helper)

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

Sorry, something went wrong.

@mreid-tt mreid-tt self-assigned this Feb 12, 2023
@mreid-tt mreid-tt added the dotnet Related to dotnet (core) label Feb 12, 2023
@mreid-tt mreid-tt changed the title Framework patch Framework: fix installer, add arch vars Feb 12, 2023
@mreid-tt mreid-tt requested a review from hgy59 February 12, 2023 12:43
@mreid-tt mreid-tt mentioned this pull request Feb 12, 2023
Merged
7 tasks
This was referenced Feb 12, 2023
Merged
Merged
hgy59
hgy59 approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreid-tt mreid-tt merged commit e39dceb into SynoCommunity:master Feb 12, 2023
@mreid-tt mreid-tt deleted the framework-patch branch February 12, 2023 13:23
th0ma7
th0ma7 requested changes Feb 12, 2023
View reviewed changes
@th0ma7
Copy link
Contributor

th0ma7 commented Feb 12, 2023

Seems I wasn't fast enough to provide my review 🤷

@mreid-tt
Copy link
Contributor Author

Seems I wasn't fast enough to provide my review 🤷

Sorry about that. I did respond above and we can probably incorporate your ideas in a future PR.

@mreid-tt mreid-tt mentioned this pull request Feb 14, 2023
Merged
@mreid-tt mreid-tt mentioned this pull request Mar 29, 2023
Merged
10 tasks
AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
@mreid-tt
Framework: fix installer, add arch vars (SynoCommunity#5602)
98c9758 
* Add dotnet 6.0 arch list
* Fix service installer call_func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgy59 hgy59

@th0ma7 th0ma7

Assignees

@mreid-tt mreid-tt

Labels
dotnet Related to dotnet (core) framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing dotNET *arr packages with ARMv7 archs
3 participants
@mreid-tt @th0ma7 @hgy59