Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload: Allow relative between different uploaders #205

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

jerry-skydio
Copy link
Collaborator

@jerry-skydio jerry-skydio commented Dec 28, 2024

When originally adding Uploader, we didn't allow relative between
different uploaders to be safe / prevent risk of mistakes. It seems
like there's a decently large use case for this though, so switch to
allowing it.

Topic: relup
Uploader: who
Reviewers: aaron, brian-k

When originally adding Uploader, we didn't allow relative between
different uploaders to be safe / prevent risk of mistakes. It seems
like there's a decently large use case for this though, so switch to
allowing it.

Topic: relup
Uploader: who
Reviewers: aaron, brian-k
@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Dec 28, 2024

Reviews in this chain:
#205 upload: Allow relative between different uploaders

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Dec 28, 2024

# head base diff date summary
0 4a14bbd9 c7b92e83 diff Dec 28 16:54 PM 1 file changed, 10 deletions(-)
1 bdffc6d6 c7b92e83 diff Dec 28 16:57 PM 0 files changed
2 5d4048f9 c7b92e83 diff Dec 28 17:27 PM 1 file changed, 1 insertion(+)
3 bdffc6d6 c7b92e83 diff Dec 28 17:31 PM 1 file changed, 1 deletion(-)

Copy link
Contributor

@aaron-skydio aaron-skydio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, yeah this will definitely get some use. Can we add an example of how to use this somewhere, maybe in the README?

@jerry-skydio jerry-skydio merged commit ea26a45 into main Jan 2, 2025
9 checks passed
@jerry-skydio jerry-skydio deleted the who/revup/main/relup branch January 2, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants