Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Don't swallow all push output #204

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

jerry-skydio
Copy link
Collaborator

@jerry-skydio jerry-skydio commented Dec 28, 2024

In certain situations "git push" will need to auth interactively. However
we don't show the user any output from git push because of github's automatic
"create a pr test" that is generally not what we want since revup handles pr
creation. This does make these auth situations confusing though.

Instead of hiding all output, default to showing output except for lines prefixed
with "remote:" which will get hidden.

Topic: outpush3
Closes: #33
Reviewers: aaron, brian-k

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Dec 28, 2024

Reviews in this chain:
#204 git: Don't swallow all push output

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Dec 28, 2024

# head base diff date summary
0 7c4cf4bd c7b92e83 diff Dec 28 16:24 PM 2 files changed, 20 insertions(+), 6 deletions(-)
1 e56d1346 c7b92e83 diff Dec 28 16:25 PM 0 files changed
2 0098043c c7b92e83 diff Dec 28 16:27 PM 1 file changed, 1 insertion(+)
3 acb406f3 c7b92e83 diff Dec 28 16:54 PM 0 files changed
4 ac7d6e6f 4a14bbd9 diff Dec 28 16:55 PM 1 file changed, 10 deletions(-)
5 8f309fa9 bdffc6d6 rebase Dec 28 16:57 PM 0 files changed
6 0098043c c7b92e83 diff Dec 28 17:20 PM 0 files changed
7 f3377dfa c7b92e83 diff Dec 28 17:34 PM 1 file changed, 1 insertion(+), 1 deletion(-)
8 8167610f 159f964c diff Jan 2 12:00 PM 1 file changed, 3 insertions(+), 3 deletions(-)
9 df699bf5 ea26a45d diff Jan 2 12:34 PM 1 file changed, 3 insertions(+), 1 deletion(-)

@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/outpush3 branch from 7c4cf4b to e56d134 Compare December 28, 2024 21:25
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/outpush3 branch 3 times, most recently from acb406f to ac7d6e6 Compare December 28, 2024 21:55
@jerry-skydio jerry-skydio changed the base branch from main to who/revup/main/relup December 28, 2024 21:55
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/outpush3 branch from ac7d6e6 to 8f309fa Compare December 28, 2024 21:57
@jerry-skydio jerry-skydio changed the base branch from who/revup/main/relup to main December 28, 2024 22:20
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/outpush3 branch 2 times, most recently from 0098043 to f3377df Compare December 28, 2024 22:34
Copy link
Contributor

@aaron-skydio aaron-skydio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. I guess we'll hide other things github might say, like I think it'll tell you about branch protection settings and such if you can't force push?, but that's probably ok.

Some alternatives are maybe to print the whole thing if the push fails, which I think we aren't doing based on my read, or to explicitly filter only the bit suggesting you open a PR, which would be brittle

revup/shell.py Outdated Show resolved Hide resolved
revup/shell.py Outdated Show resolved Hide resolved
revup/shell.py Outdated Show resolved Hide resolved
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/outpush3 branch from f3377df to 8167610 Compare January 2, 2025 17:00
In certain situations "git push" will need to auth interactively. However
we don't show the user any output from git push because of github's automatic
"create a pr test" that is generally not what we want since revup handles pr
creation. This does make these auth situations confusing though.

Instead of hiding all output, default to showing output except for lines prefixed
with "remote:" which will get hidden.

Topic: outpush3
Closes: #33
Reviewers: aaron, brian-k
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/outpush3 branch from 8167610 to df699bf Compare January 2, 2025 17:34
@jerry-skydio
Copy link
Collaborator Author

added something to also printout the output if running with --verbose, i think that handles the same need as "print the whole thing if the push fails" but is simpler

@jerry-skydio jerry-skydio merged commit 2bcb09f into main Jan 2, 2025
5 checks passed
@jerry-skydio jerry-skydio deleted the jerry/revup/main/outpush3 branch January 2, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password protected keys unsupported
2 participants