-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git: Don't swallow all push output #204
Conversation
Reviews in this chain: |
|
7c4cf4b
to
e56d134
Compare
acb406f
to
ac7d6e6
Compare
4a14bbd
to
bdffc6d
Compare
ac7d6e6
to
8f309fa
Compare
0098043
to
f3377df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. I guess we'll hide other things github might say, like I think it'll tell you about branch protection settings and such if you can't force push?, but that's probably ok.
Some alternatives are maybe to print the whole thing if the push fails, which I think we aren't doing based on my read, or to explicitly filter only the bit suggesting you open a PR, which would be brittle
f3377df
to
8167610
Compare
In certain situations "git push" will need to auth interactively. However we don't show the user any output from git push because of github's automatic "create a pr test" that is generally not what we want since revup handles pr creation. This does make these auth situations confusing though. Instead of hiding all output, default to showing output except for lines prefixed with "remote:" which will get hidden. Topic: outpush3 Closes: #33 Reviewers: aaron, brian-k
8167610
to
df699bf
Compare
added something to also printout the output if running with --verbose, i think that handles the same need as "print the whole thing if the push fails" but is simpler |
In certain situations "git push" will need to auth interactively. However
we don't show the user any output from git push because of github's automatic
"create a pr test" that is generally not what we want since revup handles pr
creation. This does make these auth situations confusing though.
Instead of hiding all output, default to showing output except for lines prefixed
with "remote:" which will get hidden.
Topic: outpush3
Closes: #33
Reviewers: aaron, brian-k