Skip to content

Commit

Permalink
upload: Allow relative between different uploaders
Browse files Browse the repository at this point in the history
When originally adding Uploader, we didn't allow relative between
different uploaders to be safe / prevent risk of mistakes. It seems
like there's a decently large use case for this though, so switch to
allowing it.

Topic: relup
Uploader: who
Reviewers: aaron, brian-k
  • Loading branch information
jerry-skydio committed Jan 2, 2025
1 parent 159f964 commit ea26a45
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions revup/topic_stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -647,16 +647,6 @@ async def populate_relative_reviews(self, uploader: str, branch_format: str) ->
f" {topic.tags[TAG_BRANCH]} for topic {name}"
)

if (
topic.tags[TAG_UPLOADER]
and topic.relative_topic
and topic.tags[TAG_UPLOADER] != topic.relative_topic.tags[TAG_UPLOADER]
):
raise RevupUsageException(
f"Topic {name} has uploader '{topic.tags[TAG_UPLOADER]}' while relative topic"
f" {topic.relative_topic.name} has uploader"
f" {topic.relative_topic.tags[TAG_UPLOADER] or '{}'}"
)
topic_uploader = min(topic.tags[TAG_UPLOADER]) if topic.tags[TAG_UPLOADER] else uploader
topic_branch_format = (
min(topic.tags[TAG_BRANCH_FORMAT]).lower()
Expand Down

0 comments on commit ea26a45

Please sign in to comment.