[Fix] Blank continue action when revisiting a saved Slack setup#299
Merged
Conversation
SlackSetupExperience's intro screen owns the step action buttons, and it is skipped when the Slack config is already saved (savedSatisfied). But StepAuthEnvVars's providerOwnsActions check was missing the matching !savedSatisfied clause, so revisiting the auth step with saved Slack credentials rendered the value form with no action button at all, stranding the user on the page. Align providerOwnsActions with the intro guard and add a regression test for the saved-Slack revisit path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
No code issues found. See task The fix correctly adds the missing Reviewed c2503a5 |
This was referenced Jul 13, 2026
brunobergher
pushed a commit
that referenced
this pull request
Jul 14, 2026
SlackSetupExperience's intro screen owns the step action buttons, and it is skipped when the Slack config is already saved (savedSatisfied). But StepAuthEnvVars's providerOwnsActions check was missing the matching !savedSatisfied clause, so revisiting the auth step with saved Slack credentials rendered the value form with no action button at all, stranding the user on the page. Align providerOwnsActions with the intro guard and add a regression test for the saved-Slack revisit path. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The setup auth step renders the filled-in Slack credential fields but nothing below them — no way to continue, in Chrome and Safari alike. Reads as a "blank page" below the form.
Root cause
Two conditions that must mirror each other drifted apart in e36f573:
SlackSetupExperienceshows its intro screen (which owns the Create Slack app / Enter values manually / Back buttons) only when!showManualSlackValues && !runtimeSatisfied && !savedSatisfied.StepAuthEnvVarssuppresses its own action button wheneverproviderOwnsActionsis true — but that check was missing the!savedSatisfiedclause.So with Slack already configured (
savedSatisfied), the intro is skipped and the value form is shown, yetStepAuthEnvVarsstill believes the intro owns the actions → no button rendered anywhere, user is stranded. Deterministic, hence identical in every browser.Fix
Add the missing
!selectedProvider.savedSatisfiedclause toproviderOwnsActions, with a comment tying it to the intro guard it must stay in sync with. The saved-Slack revisit now renders an enabled Continue button.Verification
StepAuthEnvVars.client.test.tsx: 17/17 pass@roomote/webtypecheck clean🤖 Generated with Claude Code