Skip to content

[Chore] Release Roomote 0.4.2 hotfix for saved Slack continue#302

Merged
roomote-roomote[bot] merged 2 commits into
mainfrom
hotfix/v0.4.2-slack-continue
Jul 13, 2026
Merged

[Chore] Release Roomote 0.4.2 hotfix for saved Slack continue#302
roomote-roomote[bot] merged 2 commits into
mainfrom
hotfix/v0.4.2-slack-continue

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

Hotfix request for #299 only — not a full develop cut.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Hotfix release 0.4.2 cut from current production (main / v0.4.1) with only the already-merged #299 Slack setup fix:

  • Cherry-picks the continue-button fix so revisiting setup with saved Slack credentials shows an enabled Continue again (no blank actions strip).
  • Bumps the single product version 0.4.10.4.2 and adds the matching changelog section.
  • Intentionally excludes other unreleased work that is currently on develop so this ships as a true production hotfix.

Changelog (0.4.2)

  • Onboarding Slack setup no longer strands revisits with saved credentials on a form with no Continue action: the step button is shown again when the intro screen is skipped.

How it was tested

  • pnpm run test:release-scripts — 8/8 pass
  • @roomote/web regression suite StepAuthEnvVars.client.test.tsx (includes the saved-Slack revisit case) — 15/15 pass
  • Pre-push: lint:fast, check-types:fast, and knip on the hotfix branch

After merge (operators)

  1. Merge this PR into main with a merge commit (main rules require it). Tagging / GHCR publish follows the existing main release workflows for v0.4.2.
  2. After v0.4.2 is tagged, merge the companion develop sync #303 so develop records 0.4.2 and the next normal cut does not re-use that tag.

Related PRs

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

daniel-lxs and others added 2 commits July 13, 2026 22:31
SlackSetupExperience's intro screen owns the step action buttons, and it
is skipped when the Slack config is already saved (savedSatisfied). But
StepAuthEnvVars's providerOwnsActions check was missing the matching
!savedSatisfied clause, so revisiting the auth step with saved Slack
credentials rendered the value form with no action button at all,
stranding the user on the page.

Align providerOwnsActions with the intro guard and add a regression
test for the saved-Slack revisit path.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Hotfix-only cut from main with the #299 Slack setup Continue fix.
@roomote-roomote

roomote-roomote Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed the 0.4.2 hotfix. The providerOwnsActions fix in StepAuthEnvVars.tsx now exactly mirrors SlackSetupExperience's intro guard (!showManualSlackValues && !runtimeSatisfied && !savedSatisfied), so a saved-Slack revisit correctly falls through to the step-owned Continue button instead of rendering no action. The regression test covers that path, and the version bump plus changelog entry are consistent (no lingering 0.4.1 references).

Reviewed 09c42fd

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review July 13, 2026 22:38
@roomote-roomote
roomote-roomote Bot merged commit 8a7a3e2 into main Jul 13, 2026
18 checks passed
@roomote-roomote
roomote-roomote Bot deleted the hotfix/v0.4.2-slack-continue branch July 13, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants