Skip to content

[Fix] Blank continue action when revisiting a saved Slack setup #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-lxs merged 1 commit into from
Jul 13, 2026
Merged

[Fix] Blank continue action when revisiting a saved Slack setup #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions apps/web/src/app/(onboarding)/setup/StepAuthEnvVars.client.test.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion apps/web/src/app/(onboarding)/setup/StepAuthEnvVars.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,16 @@ export function StepAuthEnvVars({
selectedProvider.runtimeSatisfied;
const selectedProviderHasEditableFields =
visibleFields.some((field) => !field.runtimeSatisfied) ?? false;
// Slack "owns" the step actions only while its intro screen is shown, which
// is the same condition SlackSetupExperience uses to render that intro. If a
// saved (or runtime) config is being edited instead, the intro is hidden and
// this step must render its own action button — otherwise there is no way to
// continue. Keep this in sync with SlackSetupExperience's intro guard.
const providerOwnsActions =
selectedProvider?.id === 'slack' &&
!showManualSlackValues &&
!selectedProvider.runtimeSatisfied;
!selectedProvider.runtimeSatisfied &&
!selectedProvider.savedSatisfied;

if (bootstrapMode && selectedProviderRuntimeConfigured) {
return (
Expand Down
Loading