Repository navigation
getSkillByName: 1.14d names behind legacySkillNames, skills.txt otherwise - #67
Merged
Merged
Conversation
ResurrectedTrader
added this pull request to stack #78
October 6, 2026 23:12
ResurrectedTrader
force-pushed
the
legacy-skill-names
branch
from
October 6, 2026 23:14
45ef312 to
7451f01
Compare
ResurrectedTrader
force-pushed
the
legacy-skill-names
branch
3 times, most recently
from
October 7, 2026 07:25
eececf1 to
d0b092d
Compare
…wise getSkillByName (and setSkill with a skill name) resolve names through the 1.14d table of localized skill names scripts use, where for example "Phoenix Strike" is skills.txt's "Royal strike". The table moves from the lod114d backend into the contract, with its lookup game::LegacySkillByName (Common.cpp). A new framework compatibility flag, legacySkillNames (on by default), selects it: the backend's game::GetSkillByName answers from the shared table while the flag is on, and otherwise scans the game's skills.txt - 1.14d, whose compiled records carry no name, walks the skills.txt link list the game keys by the `skill` column. Script-visible behaviour: unchanged while the flag is on (the default). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ResurrectedTrader
force-pushed
the
legacy-skill-names
branch
from
October 7, 2026 07:29
d0b092d to
01385d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSkillByName(andsetSkillwith a name) resolve through the 1.14d table of localized skill names scripts use (e.g. "Phoenix Strike", which is skills.txt's "Royal strike").game::LegacySkillByName(Common.cpp).legacySkillNames(on by default), selects it; with it off, the backend'sGetSkillByNamescans the game's skills.txt instead (1.14d walks the skills.txt link list the game keys by theskillcolumn).Script-visible: unchanged while the flag is on (the default).
Stack
Stacked on #66 (this PR's base branch); it depends on that change and the ones below it. Merge in order; once the base merges, this PR is retargeted to
main(automatically when the merged branch is deleted).Verification
build.ps1 Release(Win32, the 1.14d DLL): buildsbuild.ps1 test: 169/169 passbuild.ps1 check-format: clean🤖 Generated with Claude Code