Repository navigation
characterstate: raw game data, game type, backend and stack counts - #68
Merged
Merged
Conversation
ResurrectedTrader
added this pull request to stack #78
October 6, 2026 23:12
ResurrectedTrader
force-pushed
the
characterstate-raw-game-data
branch
from
October 6, 2026 23:14
d0007f0 to
593d856
Compare
ResurrectedTrader
force-pushed
the
characterstate-raw-game-data
branch
4 times, most recently
from
October 7, 2026 07:29
2e41529 to
627ca49
Compare
- core: CompatibilityFlags::BypassScope. While one is alive, IsEnabled() answers false for every flag on the thread that created it; stored states and every other thread are untouched. Scopes nest. - The character-state capture (OnTick, RecordKill) runs under one, so the snapshot sent to the D2BotNG manager carries the game's own data rather than the script-facing view. docs/compatibility.md gains a "Raw game data" section. - The snapshot names the game it describes: a top-level `backend` (game::GetBackendVersion()) and identity.gameType. Items on an advanced stash page carry their stack size as `stackCount`, and the wearer its `lastUsedSkill` (a new Unit::LastUsedSkill(); left out when there is none). All keys are additive; schemaVersion stays 2. - GetBackendVersion() reads the running game executable's version resource once and formats it "LOD/<version>" (1.14.3.71 -> "LOD/1.14d"), via a new utils::GetModuleVersion that parses the FileVersion string (falling back to the numeric FILEVERSION). The startup log line names it, and analytics' backendVersion follows (docs/analytics.md). Script-visible behaviour: none. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ResurrectedTrader
force-pushed
the
characterstate-raw-game-data
branch
from
October 7, 2026 07:30
627ca49 to
3452b3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Character-state snapshot (sent to the D2BotNG manager) improvements:
CompatibilityFlags::BypassScope- while alive,IsEnabled()answers false for every flag on the creating thread only; stored states and other threads are untouched; scopes nest.OnTick,RecordKill) runs under one, so the snapshot carries the game's own data rather than the script-facing view. docs/compatibility.md gains a "Raw game data" section.backend,identity.gameType,stackCounton items of advanced stash pages, and the wearer'slastUsedSkill(newUnit::LastUsedSkill()).GetBackendVersion()reads the running game executable's version resource once and returns"LOD/<version>"(1.14.3.71 ->"LOD/1.14d"; previously the fixed"1.14d"), via a newutils::GetModuleVersion. The startup log line names it; analytics'backendVersionfollows (docs/analytics.md).No script-visible change.
Stack
Stacked on #67 (this PR's base branch); it depends on that change and the ones below it. Merge in order; once the base merges, this PR is retargeted to
main(automatically when the merged branch is deleted).Verification
build.ps1 Release(Win32, the 1.14d DLL): buildsbuild.ps1 test: 169/169 passbuild.ps1 check-format: clean🤖 Generated with Claude Code