-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Add fixed wing rate control module #20237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
242309b to
a239974
Compare
3e9cdeb to
823f655
Compare
3e81672 to
e8b3149
Compare
Member
Author
|
Backported #20286 |
3961730 to
9552c47
Compare
9552c47 to
a25d029
Compare
a25d029 to
77a71ce
Compare
Member
Author
|
Rebased |
77a71ce to
87c88cc
Compare
87c88cc to
219bd94
Compare
Member
Author
|
Rebased on top of #20502 |
f87cfa7 to
320f77a
Compare
320f77a to
a79c140
Compare
Contributor
|
I flight tested it today on a small tiltrotor VTOL: https://review.px4.io/plot_app?log=ac92bb1e-befe-4afe-9240-198dfdfacd2b. Didn't notice anything extraordinary so far, looks all good! |
Member
Author
c0d47dd to
323d9c6
Compare
Member
Author
|
Rebased |
This commit separates the rate control functionality out of fw_att_control
Cleanup includes
Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
…callback topic Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
…encies Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
4b12ebf to
86f63fe
Compare
dagar
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
The
fw_att_controlmodule were controlling both attitude and body rate setpoints. While this has been working great, this makes it hard to integrate other control methods on either side of the cascasded loop.Therefore, this PR proposes adding a separate
fw_rate_controlmodule that pulls out the rate control functionality from thefw_att_controlmodule.Describe your solution
This PR adds a fixed wing rate control module, where we can potentially swap out the controller to other controllers(out of tree modules)
Adding the rate controller as a separate module has the following advantages
This is still a WIP, and I have noticed a few things that needs to be resolved before we can actually merge this approach
fw_rate_controlstill needs to subscribe tovehicle_attitude_setpointmessage since the reset rate integral is included in thevehicle_attitude_setpoint(FW separate reset integrals for attitude and rate setpoint messages #20502)Test data / coverage
Tested in SITL
Additional context