Namelist options for DMS tuning #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasTorsvik
requested review from
JorgSchwinger,
jmaerz and
matsbn
as code owners
1 task
jmaerz
approved these changes
Dec 11, 2025
Collaborator
jmaerz
left a comment
jmaerz
left a comment
There was a problem hiding this comment.
Fine with the changes - potentially consider my previous comment.
hamocc/mo_param_bgc.F90
Outdated
| real(rp), protected :: dmsp1 = 10._rp ! 2*5. production with temp | ||
| real(rp), protected :: dmsp2 = 0.0011_rp | ||
| real(rp), protected :: dmsp3 = 0.0864_rp ! bacterial removal, but reduced 50% to increase dms emissions | ||
| real(rp), protected :: dmsp3 = 0.1296_rp ! bacterial removal, but reduced 50% to increase dms emissions |
Collaborator
There was a problem hiding this comment.
Hi @TomasTorsvik , I am in general fine with the changes, but if time allows: maybe put the original values of Kloster et al. 2006 in the comment lines? Further: I didn't check the values - @JorgSchwinger might wish to have a second look.
Contributor
Author
There was a problem hiding this comment.
Yes, that makes sense. I see that the comment line with "50%" is wrong / needs updating.
github-project-automation
bot
moved this from Todo
to In Progress
in NorESM Development
JorgSchwinger
approved these changes
Dec 11, 2025
hamocc/mo_param_bgc.F90
Outdated
| real(rp), protected :: dmsp3 = 0.1296_rp ! bacterial removal, but reduced 50% to increase dms emissions | ||
| real(rp), protected :: dmsp4 = 1.25_rp*0.10_rp ! production with delcar, but reduced by ~7% | ||
| real(rp), protected :: dmsp5 = 1.25_rp*0.02_rp ! production with delsil, but increased by a factor of ~2 | ||
| real(rp), protected :: dmsp5 = 1.36e-02_rp ! production with delsil |
Contributor
There was a problem hiding this comment.
Is it a good idea to already change the default values?
I would slightly prefer to leave them unchanged for now, do the tuning simulations with namelist and then update the defaults for the final release.
Contributor
Author
There was a problem hiding this comment.
OK, that makes sense. I will revert the changes for default values.
github-project-automation
bot
moved this from In Progress
to Done
in NorESM Development
17 tasks
gold2718
added a commit
to NorESMhub/NorESM
that referenced
this pull request
Dec 17, 2025
noresm3_0_beta09: Update CTSM, BLOM - CIME: `cime6.1.143_noresm_v1` - ccs_config: `ccs_config_noresm0.0.55` - BLOM: `v1.12.22` - NorESMhub/BLOM#704 - CAM: `noresm3_0_021_cam6_4_121` - NorESMhub/CAM#245 - CICE: `noresm_cice6_6_1_20251129_v1` - CISM: `cismwrap_2_2_007_noresm_v1` - CTSM: `ctsm5.4.002_noresm_v1` - NorESMhub/CTSM#178 - FATES: fates_params_sci.1.88.6_api.42.0.0_14pft_nor_sci1_api1 - MOSART: `mosart1.1.12_noresm_v1` - WW3: `ww3_interface_noresm0.0.18` - CISM: `cismwrap_2_2_007_noresm_v1` - CMEPS: `cmeps1.1.23_noresm_v1` - CDEPS: `cdeps1.0.83_noresm_v2` Testing: - `prealpha_noresm` all PASS (new baseline noresm_develop/noresm3_0_beta09) - `aux_cam_noresm` several expected BASELINE failures and unexpected SUBMIT failures due to unavailability of input data from new NCAR server - `aux_clm_noresm` all PASS (new baseline ctsm_develop/ctsm5.4.002_noresm_v1) - `aux_blom_noresm` all PASS (new baseline blom_develop/noresm3_0_beta09)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option for tuning constatns
dmsp3,dmsp4,dmsp5through namelist options. Default values: