Skip to content

Namelist options for DMS tuning #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasTorsvik merged 2 commits into from
Dec 11, 2025
Merged

Namelist options for DMS tuning #704

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9b417b
Namelist options for DMS tuning
TomasTorsvik Dec 11, 2025
576caa7
Revert default values, to be updated later
TomasTorsvik Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions cime_config/namelist_definition_blom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6063,6 +6063,36 @@
<desc>Half-saturation constant for NO2 for nitrification on NO2 (kmol/m3)</desc>
</entry>

<entry id="dmsp3">
<type>real</type>
<category>bgcparams</category>
<group>bgcparams</group>
<values>
<value>None</value>
</values>
<desc>bacterial removal; constant for DMS scheme (Kloster et al. (2006), Table 1)</desc>
</entry>

<entry id="dmsp4">
<type>real</type>
<category>bgcparams</category>
<group>bgcparams</group>
<values>
<value>None</value>
</values>
<desc>production with delcar; constant for DMS scheme (Kloster et al. (2006), Table 1)</desc>
</entry>

<entry id="dmsp5">
<type>real</type>
<category>bgcparams</category>
<group>bgcparams</group>
<values>
<value>None</value>
</values>
<desc>production with delsil; constant for DMS scheme (Kloster et al. (2006), Table 1)</desc>
</entry>

<entry id="wlin">
<type>real</type>
<category>bgcparams</category>
Expand Down
13 changes: 7 additions & 6 deletions hamocc/mo_param_bgc.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,9 +496,9 @@ module mo_param_bgc
! Set constants for dms scheme following Kloster et al. (2006), Table 1
real(rp), protected :: dmsp1 = 10._rp ! 2*5. production with temp
real(rp), protected :: dmsp2 = 0.0011_rp
real(rp), protected :: dmsp3 = 0.0864_rp ! bacterial removal, but reduced 50% to increase dms emissions
real(rp), protected :: dmsp3 = 0.1296_rp ! bacterial removal, but reduced 50% to increase dms emissions
Copy link
Collaborator

@jmaerz jmaerz Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TomasTorsvik , I am in general fine with the changes, but if time allows: maybe put the original values of Kloster et al. 2006 in the comment lines? Further: I didn't check the values - @JorgSchwinger might wish to have a second look.

Copy link
Contributor Author

@TomasTorsvik TomasTorsvik Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense. I see that the comment line with "50%" is wrong / needs updating.

real(rp), protected :: dmsp4 = 1.25_rp*0.10_rp ! production with delcar, but reduced by ~7%
real(rp), protected :: dmsp5 = 1.25_rp*0.02_rp ! production with delsil, but increased by a factor of ~2
real(rp), protected :: dmsp5 = 1.36e-02_rp ! production with delsil
Copy link
Contributor

@JorgSchwinger JorgSchwinger Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a good idea to already change the default values?

I would slightly prefer to leave them unchanged for now, do the tuning simulations with namelist and then update the defaults for the final release.

Copy link
Contributor Author

@TomasTorsvik TomasTorsvik Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that makes sense. I will revert the changes for default values.

real(rp), protected :: dmsp6 = 0.1e-07_rp ! half saturation microbial

! Scaling factor for pH dependency (used if with_dmsph=.true.)
Expand Down Expand Up @@ -724,10 +724,11 @@ subroutine read_bgcnamelist()
bkoxdnra_sed,bkdnra_sed,q10anh4nitr_sed, &
bkoxamox_sed,bkanh4nitr_sed,q10ano2nitr_sed, &
bkoxnitr_sed,bkano2nitr_sed,sed_alpha_poc,sed_qual_sc, &
sed_denit,sed_sulf, &
sed_O2thresh_hypoxic,sed_O2thresh_sulf,sed_NO3thresh_sulf,&
gammapsl,gammazsl,alphasl,alphasr,docl_remin,docsl_remin, &
docsr_remin,docr_remin,yield_n2o_inf,bkamoxn2o
sed_denit,sed_sulf,sed_O2thresh_hypoxic, &
sed_O2thresh_sulf,sed_NO3thresh_sulf,gammapsl, &
gammazsl,alphasl,alphasr,docl_remin,docsl_remin, &
docsr_remin,docr_remin,yield_n2o_inf,bkamoxn2o, &
dmsp3,dmsp4,dmsp5

if (mnproc.eq.1) then
write(io_stdo_bgc,*)
Expand Down