Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantheon.elementary-greeter: actually fix the crash #159732

Merged
merged 2 commits into from
Feb 20, 2022
Merged

pantheon.elementary-greeter: actually fix the crash #159732

merged 2 commits into from
Feb 20, 2022

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Feb 13, 2022 •
edited
Loading

Motivation for this change

Fixes #151609

So far this is testing propose only. While we are still waiting response from upstream, I am going to use this patch daily until the next Pantheon update happens and if there is still no response, I will do it downstream and revisit it on 6 -> 7 bump.

cc @OPNA2608

Also cc some people in #140513, sorry for almost forgetting that issue...
@davidarmstronglewis @yellowgh0st

The crash is currently 100% reproducible for me with strictly the following steps:

2a376bb dropped the previous patch (which simply revert the bad commit with the cost of dropping support for accent color for login check)

$ rm -rf nixos.qcow2
$ nix run github:bobby285271/test-pantheon --override-input nixpkgs github:NixOS/nixpkgs/2a376bb3dadf65750dad00b79c315f96b90b90c9
  1. Login with password test, change accent color to io.elementary.stylesheet.mint
  2. In VM, Shut Down -> Restart
  3. See crash

And to test the fix

$ nix run github:bobby285271/test-pantheon --override-input nixpkgs github:NixOS/nixpkgs/f29955df819d176e269725557876fca38ecf10d7
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bobby285271 bobby285271 added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Feb 13, 2022
@github-actions github-actions bot added the 6.topic: pantheon The Pantheon desktop environment label Feb 13, 2022
@ofborg ofborg bot requested a review from davidak February 13, 2022 03:14
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Feb 13, 2022
@bobby285271 bobby285271 mentioned this pull request Feb 13, 2022
Closed
@bobby285271
Revert "pantheon.elementary-greeter: add patch for revert pull reques…
2a376bb 
…t 566"

This reverts commit 34d5d14.
@bobby285271
pantheon.elementary-greeter: actually fix the crash
f29955d 
Fixed a use-after-free issue where logged_in_context is used in update_style().
There are several reports for this but upstream has no action for this so far during the 6.x cycle.
See the provided link for more details.
@bobby285271
Copy link
Member Author

bobby285271 commented Feb 19, 2022 •
edited
Loading

Going to land this tomorrow.
@ofborg test pantheon

@bobby285271 bobby285271 removed the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Feb 19, 2022
@bobby285271 bobby285271 marked this pull request as ready for review February 19, 2022 09:22
@bobby285271 bobby285271 merged commit 9042c88 into master Feb 20, 2022
@bobby285271 bobby285271 deleted the pantheon branch February 20, 2022 03:31
@bobby285271 bobby285271 mentioned this pull request Feb 24, 2022
Merged
13 tasks
@bobby285271
Copy link
Member Author

The crash and the fix has been confirmed and accepted on upstream.

21.11 backport happens in #161642

@bobby285271 bobby285271 added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak Awaiting requested review from davidak

Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pantheon greeter crashes since NixOS 21.11 upgrade
1 participant
@bobby285271