-
-
Notifications
You must be signed in to change notification settings - Fork 15k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pantheon.elementary-greeter: actually fix the crash
Fixed a use-after-free issue where logged_in_context is used in update_style(). There are several reports for this but upstream has no action for this so far during the 6.x cycle. See the provided link for more details.
- Loading branch information
1 parent
2aad980
commit 94b03cc
Showing
2 changed files
with
24 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
pkgs/desktops/pantheon/desktop/elementary-greeter/fix-crash.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
diff --git a/src/Cards/UserCard.vala b/src/Cards/UserCard.vala | ||
index 83df22c..8cd917e 100644 | ||
--- a/src/Cards/UserCard.vala | ||
+++ b/src/Cards/UserCard.vala | ||
@@ -42,6 +42,7 @@ public class Greeter.UserCard : Greeter.BaseCard { | ||
private Gtk.Stack login_stack; | ||
private Greeter.PasswordEntry password_entry; | ||
|
||
+ private SelectionCheck logged_in; | ||
private unowned Gtk.StyleContext logged_in_context; | ||
private weak Gtk.StyleContext main_grid_style_context; | ||
private weak Gtk.StyleContext password_entry_context; | ||
@@ -214,7 +215,7 @@ public class Greeter.UserCard : Greeter.BaseCard { | ||
}; | ||
avatar_overlay.add (avatar); | ||
|
||
- var logged_in = new SelectionCheck () { | ||
+ logged_in = new SelectionCheck () { | ||
halign = Gtk.Align.END, | ||
valign = Gtk.Align.END | ||
}; |