[21.11] Pantheon 6.1 backports 2022-02-24

[bobby285271]

Motivation for this change

Monthly Pantheon update backport for 21.11. Upstream is shifting focus to Pantheon 7 so there is mostly no work for us.

• Partly backports Pantheon updates 2022-02-01 #157716
• Backports pantheon.elementary-greeter: actually fix the crash #159732
• Partly backports Pantheon updates 2022-02-28 #162293
• Fixes Pantheon greeter crashes since NixOS 21.11 upgrade #151609 (in another way)
• Fixes Pantheon: crash loop on start inside vmware guest #140513 (in another way)

I am excluding the appcenter patch drop from backport as I live on nixos-unstable when I don't test nixos-21.11 pantheon bumps and unfortunately I have no time to test the appcenter patch drop with the old packagekit shipped in nixos-21.11, though things should work...

Good news is that the greeter crash has been fixed on upstream a few hours ago.

Previous stable channel backport pull request

• [21.11] Pantheon 6.1 #150634
• [21.11] Pantheon 6.1 backports 2022-01-11 #154475
• [21.11] Pantheon 6.1 backports 2022-01-25 #156723

How to test on NixOS

For flakes enabled system, you can also try bobby285271/test-pantheon.

1. Clone the NixOS/nixpkgs repository and checkout to this PR, you can use the GitHub CLI tool gh.

$ gh repo clone NixOS/nixpkgs
$ cd nixpkgs
$ gh pr checkout 161642

2. Save the following NixOS configuration file as configuration.nix, you can save the file to any directory.

{ modulesPath, pkgs, config, ... }: {
  imports = [
    "${modulesPath}/virtualisation/qemu-vm.nix"
  ];

  environment.enableDebugInfo = true;
  services.xserver = {
    enable = true;
    layout = "us";
    desktopManager.pantheon.enable = true;
    desktopManager.pantheon.debug = true;
  };

  users.mutableUsers = false;

  users.extraUsers.test = {
    isNormalUser = true;
    uid = 1000;
    extraGroups = [ "wheel" "networkmanager" ];
    password = "test";
  };
  nixpkgs.config.allowAliases = false;

  virtualisation.qemu.options = [ "-device intel-hda -device hda-duplex" ];
  virtualisation.memorySize = 2048;
  virtualisation.diskSize = 8192;
}

3. Run the following command to build the packages and create a virtual machine with the above configuration. Do not forget to adjust the path to the nixpkgs checkout (/path/to/nixpkgs) and the configuration (/path/to/configuration.nix). It will take some time to build the packages, so grab some coffee while waiting.

$ env NIX_PATH=nixpkgs=/path/to/nixpkgs:nixos-config=/path/to/configuration.nix nixos-rebuild build-vm

4. You should see a message like this, run the command provided by the output:

Done. The virtual machine can be started by running /nix/store/...-nixos-vm/bin/run-nixos-vm

5. A QEMU virtual machine will be launched, wait for LightDM to start and login with the password test.

6. Test the upgrade and if you find anything wrong, please also try reproduce the issue on master then comment here with your findings so we can handle that properly (i.e. we will drop the commit here that introduces major regressions).

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[bobby285271]

@ofborg test pantheon

[bobby285271]

Result of nixpkgs-review pr 161642 run on x86_64-linux 1

2 packages built:

• pantheon.elementary-greeter
• pantheon.elementary-photos