Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Aug 13, 2025

Description

Using merge queues was talked about in the pace meeting in August. No concerns were raised and we've successfully adopted merge queues in NDSL with NOAA-GFDL/NDSL#194.

This PR configures PySHiELD tests to not only run on pull requests, but also in the merge queue (and when merging back into main - just for good measure). @fmalatino would you help me again as repo admin to do the repo configuration? Should be one-to-one from what we did in NDSL.

How Has This Been Tested?

Similar to what we have configured in NDSL. The new behavior will be apparent once we merge. I'll keep an eye out of oddities for the first couple PRs that get merged with the merge queue.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included
  • Targeted model, if this change was triggered by a model need/shortcoming

@romanc romanc force-pushed the romanc/merge-queue branch from de7848b to c67905b Compare August 14, 2025 16:18
@fmalatino fmalatino self-requested a review August 14, 2025 16:19
@fmalatino fmalatino added this pull request to the merge queue Aug 14, 2025
Merged via the queue into NOAA-GFDL:develop with commit c4c9de5 Aug 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants