Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Aug 14, 2025

Description

Looks like pace tests are broken with the current version of PySHiELD physics. We tracked it down to the last (merge) commit. This PR reverts #38, which brings things back into a working condition.

Initial work to fix this in pace (see NOAA-GFDL/pace#134) didn't work out of the box.

Looks like the error crept in because of a stale/outdated CI run on the PR. Once we have the merge queue (e.g. PR #41) in place, we won't have this problem anymore.

How Has This Been Tested?

Running CI doesn't fail pace main tests as it does for #41.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A
  • Targeted model, if this change was triggered by a model need/shortcoming: N/A

@romanc romanc marked this pull request as ready for review August 14, 2025 07:44
@romanc
Copy link
Collaborator Author

romanc commented Aug 14, 2025

@oelbert I can't assign reviewers in this repo, so here's a manual ping ...

Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need to get this back in once we've figured out the problem :/

@romanc
Copy link
Collaborator Author

romanc commented Aug 14, 2025

We do need to get this back in once we've figured out the problem :/

Let have a follow-up issue: #43

PS: I also can't merge, so feel free to push the button. Or - try your hotfix NOAA-GFDL/pace#134 with updating the pySHiELD submodule in pace. That might also square away the problem and render this PR (and issue #43) moot.

@oelbert oelbert added this pull request to the merge queue Aug 14, 2025
@oelbert
Copy link
Collaborator

oelbert commented Aug 14, 2025

I don't quite have the bandwidth for it at this moment, but I'll try to get to it when I do

@fmalatino fmalatino removed this pull request from the merge queue due to a manual request Aug 14, 2025
@fmalatino fmalatino added this pull request to the merge queue Aug 14, 2025
@fmalatino fmalatino removed this pull request from the merge queue due to the queue being cleared Aug 14, 2025
@fmalatino fmalatino merged commit 749a80f into NOAA-GFDL:develop Aug 14, 2025
3 checks passed
@romanc romanc deleted the romanc/test branch August 14, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants