Deprecate PACE_* environment variables in favor of NDSL_*
#193
Conversation
romanc
changed the title
PACE_* environment variables in favor of NDSL_*PACE_* environment variables in favor of NDSL_*
|
No opposition in today's pace meeting. Let's move ahead with this proposal. /cc @FlorianDeconinck FYI for awareness when you are back |
bensonr
left a comment
bensonr
left a comment
There was a problem hiding this comment.
Besides my one inline comment regarding documentation, the logic is ready.
twicki
left a comment
twicki
left a comment
There was a problem hiding this comment.
Looks great. Do we want an issue with this that we don't forget to move from deprication to removal of the variables in the future?
Good idea. Tracked in issue #196. |
|
Putting this back to draft because PR #192 (to be merged first) introduces docs that we'll need to update. |
We can also merge this one first and then update #192. We'll merge this one now to test the merge queue (now that #194 is merged). PR #192 will stay open for people to leave comments on the new docs added. |
…FDL#193) * Deprecate PACE_DACE_DEBUG in favor of NDSL_DACE_DEBUG * Deprecate PACE_LOGLEVEL in favor of NDSL_LOGLEVEL * Deprecate PACE_FLOAT_PRECISION in favor of NDSL_LITERAL_PRECISION * Deprecate PACE_CONSTANTS in favor of NDSL_CONSTANTS * Don't use ndsl_log before it is defined * Document correctly renamed env variable --------- Co-authored-by: Roman Cattaneo <[email protected]>
The old ones are currently deprecated and expected to be removed in the future (after a grace period). See NOAA-GFDL/NDSL#193 for more details.
The old ones are currently deprecated and expected to be removed in the future (after a grace period). See NOAA-GFDL/NDSL#193 for more details.
The old ones are currently deprecated and expected to be removed in the future (after a grace period). See NOAA-GFDL/NDSL#193 for more details. Co-authored-by: Roman Cattaneo <[email protected]>
The old ones are currently deprecated and expected to be removed in the future (after a grace period). See NOAA-GFDL/NDSL#193 for more details. Co-authored-by: Roman Cattaneo <[email protected]> Co-authored-by: Oliver Elbert <[email protected]>
3 participants
Description
This PR suggests to rename the following environment variables:
PACE_DACE_DEBUG->NDSL_DACE_DEBUGPACE_LOGLEVEL->NDSL_LOGLEVELPACE_FLOAT_PRECISION->NDSL_LITERAL_PRECISIONPACE_CONSTANTS->NDSL_CONSTANTSAll changes are made backwards compatible (for now) with deprecation warnings when using
PACE_*environment variables.NDSL_*variables will take precedence in case both variants are defined.This Pr will influence #192 because we touch
PACE_FLOAT_PRECISIONthere too.How Has This Been Tested?
By self-review of code changes and by running the CI.
Checklist:
No, but that's kind of the point here 😉