Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Sep 12, 2025

Description

The old ones are currently deprecated and expected to be removed in the future (after a grace period). See
NOAA-GFDL/NDSL#193 for more details. Apparently pace (and its tests) doesn't set any of those (which is fine). We should nevertheless update the docs for people to use the new ones.

How Has This Been Tested?

Self-review of code changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A

The old ones are currently deprecated and expected to be removed
in the future (after a grace period). See
NOAA-GFDL/NDSL#193 for more details.
@romanc romanc requested a review from fmalatino September 12, 2025 14:33
@fmalatino fmalatino added this pull request to the merge queue Sep 12, 2025
Merged via the queue into NOAA-GFDL:develop with commit 38bfce6 Sep 12, 2025
2 checks passed
@romanc romanc deleted the romanc/new-env-variables branch September 15, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants