Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Sep 12, 2025

Description

The old ones are currently deprecated and expected to be removed in the future (after a grace period). See
NOAA-GFDL/NDSL#193 for more details.

How Has This Been Tested?

All good as CI is still green.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A
  • Targeted model, if this change was triggered by a model need/shortcoming: N/A

The old ones are currently deprecated and expected to be removed in
the future (after a grace period). See
NOAA-GFDL/NDSL#193 for more details.
@romanc
Copy link
Collaborator Author

romanc commented Sep 12, 2025

/cc @fmalatino for review

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests will pass post-merge of PR 60

Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@oelbert oelbert enabled auto-merge September 15, 2025 19:21
@oelbert oelbert added this pull request to the merge queue Sep 15, 2025
Merged via the queue into NOAA-GFDL:develop with commit ae64d42 Sep 15, 2025
3 checks passed
@romanc romanc deleted the romanc/new-env-variables branch September 16, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants