Update atmos_bufr_prepobs.py for restriction logic#205
Update atmos_bufr_prepobs.py for restriction logic#205HyundeokChoi-NOAA merged 4 commits intomainfrom
Conversation
| exec_cmd() | ||
| except Exception as e: | ||
| logger.warning(f"ioda_restriction_filter.py failed: {e}") | ||
|
|
|
|
||
| logger.info(f"Running unified restriction filter using {stats_yaml}") | ||
|
|
||
| exec_cmd = Executable("python") |
There was a problem hiding this comment.
Just curious if it makes more sense to call the main function in the python script in the other PR through python (import, etc.) rather than do it this way (execute it externally). Thoughts? Is there a benefit to doing it via a subprocess?
There was a problem hiding this comment.
That’s a good point. I didn’t think about it that way initially. I’ll update the script so the task calls the main function directly instead of running it as a subprocess.
|
@CoryMartin-NOAA This failure is likely due to ioda_restriction_filter.py from DA‑Utils PR #73 not being merged into the repository yet. |
|
NOAA-EMC/DA-utils#73 has been merged, you should be able to update the hash in this PR and this can be merged |
|
@CoryMartin-NOAA Got it. I’ve updated the da-utils submodule hash to the latest develop commit. Thanks for the heads‑up. |
|
I approved this PR based on the extend I understand the entire obsForge. This PR doesn't include the application of restriction: Open a separate PR for this work, thanks! |
|
@ilianagenkova Thanks iliana. I was planning to do it. |
3 participants
This PR updates atmos_bufr_prepobs.py to integrate the new restriction‑screening workflow. The script reads restrictionFlag and restrictionExpiration from the MetaData group and determines which observations should be retained or dropped before writing the output IODA netCDF file.