Skip to content

Update atmos_bufr_prepobs.py for restriction logic #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HyundeokChoi-NOAA merged 4 commits into from
Apr 6, 2026
Merged

Update atmos_bufr_prepobs.py for restriction logic #205

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
612ce11
Update atmos_bufr_prepobs.py for restriction logic
Apr 2, 2026
a2fcfa1
Add unified restriction filter import from build/bin
Apr 2, 2026
e740766
update task import alias to restriction_filter
Apr 3, 2026
fdbbbc4
Update da-utils submodule to latest develop
Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ush/python/pyobsforge/task/atmos_bufr_prepobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,3 +266,23 @@ def finalize(self) -> None:
logger.warning(f"Failed to create summary file {ready_file}: {e}")
logger.warning("Creating an empty ready file instead")
ready_file.touch()

# Run unified restriction filter AFTER finalize
stats_yaml = os.path.join(self.task_config.DATA, "stats.yaml")

script_path = os.path.join(
self.task_config.HOMEobsforge, "build", "bin", "ioda_restriction_filter.py"
)

logger.info(f"Running unified restriction filter using {stats_yaml}")

exec_cmd = Executable("python")
Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious if it makes more sense to call the main function in the python script in the other PR through python (import, etc.) rather than do it this way (execute it externally). Thoughts? Is there a benefit to doing it via a subprocess?

Copy link
Copy Markdown
Contributor Author

@HyundeokChoi-NOAA HyundeokChoi-NOAA Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a good point. I didn’t think about it that way initially. I’ll update the script so the task calls the main function directly instead of running it as a subprocess.

exec_cmd.add_default_arg(script_path)
exec_cmd.add_default_arg("--stats")
exec_cmd.add_default_arg(stats_yaml)

try:
exec_cmd()
except Exception as e:
logger.warning(f"ioda_restriction_filter.py failed: {e}")

Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Loading